Ok, sounds good. There was one other comment I saw besides the ones about using = delete which I think is also because of what's in the spec. ( https://gem5-review.googlesource.com/c/public/gem5/+/10832). I wanted to point that out specifically just so it doesn't get lost in all the emails I'm sure gerrit is sending out.
Gabe On Mon, Jul 23, 2018 at 11:12 AM Jason Lowe-Power <ja...@lowepower.com> wrote: > Hey Gabe, > > This is fine with me. Sorry for putting off reviewing all of these. > > If there's anything that you think specifically needs to be looked at more > closely, let us know. Otherwise, as you said, since this is fairly separate > from the rest of gem5 we can be pretty laissez faire about it. > > Cheers, > Jason > > On Mon, Jul 16, 2018 at 3:44 AM Gabe Black <gabebl...@google.com> wrote: > > > Hi folks. Thank you for all your reviewing efforts so far. I know it's > not > > easy considering the scope of the effort, and that the dark inner > workings > > and far reaching expanses of systemc are not familiar to everyone. > > > > To keep the review process open to feedback while at the same time > ensuring > > (hopefully) forward process, I'm planning to institute a sliding window > of > > review timeouts, or in other words approximately 10, say, of the oldest > > pending reviews will, absent any feedback to the contrary, have a timeout > > of, for instance, a week. When a week passes with no additional feedback > > (assuming I'm not the gating factor), then I will assume there isn't any > > feedback and check in those changes. > > > > I think this is a good compromise between making sure everybody has a > > chance to voice their opinions, but also not artificially forcing > > potentially less useful feedback just to check the "I got it reviewed" > > checkbox. Also this code is in its own directory and isn't being used by > > anyone yet (it doesn't work and is gated behind a build option), so if I > do > > check in something dumb and broken, nobody else should be affected. > > > > In the spirit of this approach, please let me know if you have any > > objections. Prolonged silence will be considered consent. > > > > Gabe > > > > On Wed, Jun 20, 2018 at 6:39 PM Gabe Black <gabebl...@google.com> wrote: > > > > > Hello again folks. There are currently 90 pending systemc CLs, and more > > > will be coming. We need to close the incoming vs outgoing gap. > > > > > > On Fri, Jun 15, 2018 at 12:01 PM Jason Lowe-Power <ja...@lowepower.com > > > > > wrote: > > > > > >> Hey Boris, > > >> > > >> I think that gerrit always sends the first message when a patch is > > >> uploaded > > >> to the whole list. Then, when adding comments or updating patches > gerrit > > >> only sends emails to people that are cc'ed in gerrit. I'm not sure > what > > >> the > > >> behavior is on merges... > > >> > > >> I'm not sure what an easy way to be added to a whole set of changes > is. > > I > > >> don't think gerrit supports it. However you can add yourself as a > > reviewer > > >> (or cc) to the SystemC changes on a per changeset basis here: > > >> > > >> > > > https://gem5-review.googlesource.com/q/topic:%22systemc%22+(status:open%20OR%20status:merged) > > >> . > > >> > > >> Cheers, > > >> Jason > > >> > > >> On Fri, Jun 15, 2018 at 6:14 AM Boris Shingarov < > shinga...@labware.com> > > >> wrote: > > >> > > >> > > If you also want to be on all the reviews, > > >> > > please let me know. I don't want to unilaterally > > >> > > bomb people's inboxes if they're not interested. > > >> > > > >> > Wait. I am not sure what you are saying here. > > >> > Are you proposing to *add* so Andreas, Jason and > > >> > Matthias will receive more emails over those review > > >> > emails the dev list is receiving already? > > >> > Or are you proposing to *subtract* so that the dev > > >> > list will no longer receive the systemc reviews like > > >> > we receive now? > > >> > Personally, I am not *that* interested in SystemC > > >> > to *act* on those reviews, but I sure-as-hell enjoy > > >> > *reading* them. > > >> > Are you proposing to make this "lurk mode" unavailable? > > >> > _______________________________________________ > > >> > gem5-dev mailing list > > >> > gem5-dev@gem5.org > > >> > http://m5sim.org/mailman/listinfo/gem5-dev > > >> _______________________________________________ > > >> gem5-dev mailing list > > >> gem5-dev@gem5.org > > >> http://m5sim.org/mailman/listinfo/gem5-dev > > > > > > > > _______________________________________________ > > gem5-dev mailing list > > gem5-dev@gem5.org > > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ > gem5-dev mailing list > gem5-dev@gem5.org > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
