I can confirm it's been doing this for a while now on my end. Lots of
existing files in gem5 fail the style checker when I modify them, so it
seems to be at least somewhat recent, or people were overriding the style
checker in the past.

Ryan Gambord

On Thu, May 2, 2019, 22:58 Gabe Black <gabebl...@google.com> wrote:

> Here's another potentially related bug. There was an extra space between
> the final header and the using at the top of a .cc, and the style fixer
> decided to move the include of the corresponding .hh from the top where it
> belonged down into the list of includes in alphabetic order. It still
> complained about the headers after, but when told to fix it it made no
> changes. It seems the fixer doesn't always recognize when the
> .hh corresponding to a .cc needs to be at the top.
>
> Gabe
>
> On Thu, May 2, 2019 at 10:50 PM Gabe Black <gabebl...@google.com> wrote:
>
> > Hey folks. I just ran into a bug in the style checker/fixer, and since I
> > wanted to make sure I kept track of those so they can be fixed I thought
> I
> > would describe it here for the record. I have a cc file which had a
> single
> > system include (#include <vector>) and the include for its .hh file
> > (#include "base/loader/loader.hh"), but they were in the wrong order,
> > system and then .hh. The style checker correctly complained about the
> order
> > and offered to fix it, but when I said yes it didn't actually change
> > anything or print any messages. FYI in case somebody wants to
> investigate.
> >
> > Gabe
> >
> _______________________________________________
> gem5-dev mailing list
> gem5-dev@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to