Attention is currently required from: Ciro Santilli, Nikos Nikoleris.
Hello Ciro Santilli, Nikos Nikoleris,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/37616
to review the following change.
Change subject: arch-arm: VSTCR_EL2/VSTTBR_EL2 accessible in secure mode
only
......................................................................
arch-arm: VSTCR_EL2/VSTTBR_EL2 accessible in secure mode only
We should trigger an Undefined Instruction if those registers
are accessed in non-secure mode
Change-Id: I45ec01e9e4ae9a38d59e56a51e198b4199a7d814
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Ciro Santilli <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
---
M src/arch/arm/miscregs.cc
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/arch/arm/miscregs.cc b/src/arch/arm/miscregs.cc
index 5b97b07..82a8217 100644
--- a/src/arch/arm/miscregs.cc
+++ b/src/arch/arm/miscregs.cc
@@ -4899,9 +4899,9 @@
.hyp().mon()
.mapsTo(MISCREG_VTCR);
InitReg(MISCREG_VSTTBR_EL2)
- .hyp().mon();
+ .hypSecure().mon();
InitReg(MISCREG_VSTCR_EL2)
- .hyp().mon();
+ .hypSecure().mon();
InitReg(MISCREG_TTBR0_EL3)
.mon();
InitReg(MISCREG_TCR_EL3)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37616
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I45ec01e9e4ae9a38d59e56a51e198b4199a7d814
Gerrit-Change-Number: 37616
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Attention: Ciro Santilli <[email protected]>
Gerrit-Attention: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
