Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/58150 )
Change subject: dev-amdgpu: Add braces to stop clang compilation braces
error
......................................................................
dev-amdgpu: Add braces to stop clang compilation braces error
Additional braces are needed due to a clang compilation bug that falsely
throws a "suggest braces around initialization of subject" error. More
info on this bug is available here:
https://stackoverflow.com/questions/31555584
Change-Id: Ide5cdd260716ba06f6da4663732e39d18e00af97
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/58150
Reviewed-by: Matthew Poremba <matthew.pore...@amd.com>
Maintainer: Matthew Poremba <matthew.pore...@amd.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/dev/amdgpu/pm4_packet_processor.cc
1 file changed, 24 insertions(+), 1 deletion(-)
Approvals:
Matthew Poremba: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/amdgpu/pm4_packet_processor.cc
b/src/dev/amdgpu/pm4_packet_processor.cc
index d076944..cfd031b 100644
--- a/src/dev/amdgpu/pm4_packet_processor.cc
+++ b/src/dev/amdgpu/pm4_packet_processor.cc
@@ -166,7 +166,12 @@
q->id(), q->rptr(), q->wptr());
if (q->rptr() < q->wptr()) {
- PM4Header h{0, 0, 0, 0, 0, 0};
+ /* Additional braces here are needed due to a clang compilation bug
+ falsely throwing a "suggest braces around initialization of
+ subject" error. More info on this bug is available here:
+ https://stackoverflow.com/questions/31555584
+ */
+ PM4Header h{{{0, 0, 0, 0, 0, 0}}};
auto cb = new DmaVirtCallback<PM4Header>(
[ = ] (PM4Header header)
{ decodeHeader(q, header); }, h);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58150
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ide5cdd260716ba06f6da4663732e39d18e00af97
Gerrit-Change-Number: 58150
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
