Also, please make these sorts of large scale formatting changes 
judiciously. There's a large collection of patches out there and it can 
be non-trivial to keep them applying correctly.

Gabe

Steve Reinhardt wrote:
> I thought that we had agreed to always use braces for control 
> structures (for, if, while, etc.) since that makes it easier to 
> add/remove lines without worrying about adding/removing braces too.  I 
> don't see it mentioned either way on the coding style page, but I know 
> I've developed the habit of using braces unconditionally based on my 
> recollection of that decision.
>
> I don't really have a strong opinion either way; the #1 thing is that 
> we should agree and get it down on the wiki page so that these style 
> updates converge rather than oscillating.
>
> Steve
>
>
> On Sat, Sep 27, 2008 at 9:04 PM, Nathan Binkert <[EMAIL PROTECTED] 
> <mailto:[EMAIL PROTECTED]>> wrote:
>
>
>      void
>      copyIprs(ThreadContext *src, ThreadContext *dest)
>      {
>     -    for (int i = 0; i < NumInternalProcRegs; ++i) {
>     +    for (int i = 0; i < NumInternalProcRegs; ++i)
>             dest->setMiscRegNoEffect(i, src->readMiscRegNoEffect(i));
>     -    }
>      }
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>   

_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to