Hi everyone, First of all, sorry once again that this changeset was necessary. I thought all the regression tests passed for me before I pushed and I'm still not sure why I didn't pick this up.
Second, I noticed when checking this patch that two other regresssions were failing: ***** build/ALPHA_SE/tests/fast/long/70.twolf/alpha/tru64/inorder-timing FAILED! ***** build/ALPHA_SE/tests/fast/long/50.vortex/alpha/tru64/inorder-timing FAILED! I'm fairly sure that these are nothing to do with the recent changes I made. I reverted back to a previous version of the repository and the tests failed there too, so I guess there were problems before I introduced my own! Cheers Tim On Mon, 22 Feb 2010 09:45:41 -0500, Timothy M. Jones <tjon...@inf.ed.ac.uk> wrote: > changeset 862a31349d43 in /z/repo/m5 > details: http://repo.m5sim.org/m5?cmd=changeset;node=862a31349d43 > description: > BaseDynInst: Preserve the faults returned from read and write. > > When implementing timing address translations instead of atomic, I > forgot to preserve the faults that are returned from the read and > write calls. This patch reinstates them. > > diffstat: > > 1 file changed, 2 insertions(+), 2 deletions(-) > src/cpu/base_dyn_inst.hh | 4 ++-- > > diffs (21 lines): > > diff -r 4d4903a3e7c5 -r 862a31349d43 src/cpu/base_dyn_inst.hh > --- a/src/cpu/base_dyn_inst.hh Fri Feb 12 19:53:20 2010 +0000 > +++ b/src/cpu/base_dyn_inst.hh Sat Feb 20 20:11:58 2010 +0000 > @@ -887,7 +887,7 @@ > if (fault == NoFault) { > effAddr = req->getVaddr(); > effAddrValid = true; > - cpu->read(req, sreqLow, sreqHigh, data, lqIdx); > + fault = cpu->read(req, sreqLow, sreqHigh, data, lqIdx); > } else { > // Return a fixed value to keep simulation deterministic even > @@ -933,7 +933,7 @@ > if (fault == NoFault) { > effAddr = req->getVaddr(); > effAddrValid = true; > - cpu->write(req, sreqLow, sreqHigh, data, sqIdx); > + fault = cpu->write(req, sreqLow, sreqHigh, data, sqIdx); > } > return fault; > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > -- Timothy M. Jones http://homepages.inf.ed.ac.uk/tjones1 The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
