----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/26/#review50 -----------------------------------------------------------
src/python/m5/simulate.py <http://reviews.m5sim.org/r/26/#comment177> OK, I got ahead of myself... this doesn't compile. I may redo this whole optional argument scheme using *posargs after all. - Steve On 2010-06-27 21:30:03, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/26/ > ----------------------------------------------------------- > > (Updated 2010-06-27 21:30:03) > > > Review request for Default. > > > Summary > ------- > > sim: make Python Root object a singleton > Enforce that the Python Root SimObject is instantiated only once. > The C++ Root object already panics if more than one is created. > This change avoids the need to track what the root object > is, since it's available from Root._getInstance() (if it exists). > It's now redundant to have the user pass the root object > to functions like instantiate() (though for backwards compatibility > we continue to support this for now with a warning). > > > Diffs > ----- > > configs/common/Simulation.py 5044bb906d5a > configs/example/memtest-ruby.py 5044bb906d5a > configs/example/memtest.py 5044bb906d5a > configs/example/rubytest.py 5044bb906d5a > configs/splash2/cluster.py 5044bb906d5a > configs/splash2/run.py 5044bb906d5a > src/python/m5/simulate.py 5044bb906d5a > src/python/m5/util/__init__.py 5044bb906d5a > src/sim/Root.py 5044bb906d5a > tests/run.py 5044bb906d5a > > Diff: http://reviews.m5sim.org/r/26/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
