----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/26/#review121 -----------------------------------------------------------
Ship it! - Nathan On 2010-07-29 21:32:54, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/26/ > ----------------------------------------------------------- > > (Updated 2010-07-29 21:32:54) > > > Review request for Default. > > > Summary > ------- > > sim: make Python Root object a singleton > Enforce that the Python Root SimObject is instantiated only > once. The C++ Root object already panics if more than one is > created. This change avoids the need to track what the root > object is, since it's available from Root.getInstance() (if it > exists). It's now redundant to have the user pass the root > object to functions like instantiate(), checkpoint(), and > restoreCheckpoint(), so that arg is gone. Users who use > configs/common/Simulate.py should not notice. > > > Diffs > ----- > > configs/common/Simulation.py b28e7286990c > configs/example/memtest-ruby.py b28e7286990c > configs/example/memtest.py b28e7286990c > configs/example/rubytest.py b28e7286990c > configs/splash2/cluster.py b28e7286990c > configs/splash2/run.py b28e7286990c > src/python/m5/SimObject.py b28e7286990c > src/python/m5/simulate.py b28e7286990c > src/sim/Root.py b28e7286990c > tests/run.py b28e7286990c > > Diff: http://reviews.m5sim.org/r/26/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
