----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/53/#review66 -----------------------------------------------------------
I'm curious about the overall need for this... is there really a situation where it matters? If there's some path that's not appropriately setting/checking/ignoring the whenReady field I'd rather fix that than add this feature. src/mem/cache/BaseCache.py <http://reviews.m5sim.org/r/53/#comment205> I have a patch in my queue (thanks to Nate's suggestion) that adds some code to SimObject.__getattr__ to automatically check self._ccObject for attributes that aren't already defined on self. Once I commit that, this function (and others like it in your other patches) won't be necessary. I'll try and get that pushed so you can take advantage of it. - Steve On 2010-07-09 18:16:18, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/53/ > ----------------------------------------------------------- > > (Updated 2010-07-09 18:16:18) > > > Review request for Default. > > > Summary > ------- > > Cache: Provide a function to mark caches as ready from python. > > > Diffs > ----- > > src/mem/cache/BaseCache.py 249f174e6f37 > src/mem/cache/base.hh 249f174e6f37 > src/mem/cache/cache.hh 249f174e6f37 > src/mem/cache/cache_impl.hh 249f174e6f37 > src/mem/cache/tags/base.hh 249f174e6f37 > src/mem/cache/tags/lru.hh 249f174e6f37 > src/mem/cache/tags/lru.cc 249f174e6f37 > src/python/swig/sim_object.i 249f174e6f37 > src/sim/sim_object.hh 249f174e6f37 > src/sim/sim_object.cc 249f174e6f37 > > Diff: http://reviews.m5sim.org/r/53/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
