----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/64/#review106 -----------------------------------------------------------
util/m5/Makefile.x86 <http://reviews.m5sim.org/r/64/#comment248> Why is this necessary? Is this so it runs under SE mode? In that case I think we should make it run like before as the default since 99% of the time this will run in FS, and provide a way to inject -static for the 1% of the time it runs in SE. Compiling it as static all the time wouldn't be the end of the world, but it seems like we'd be making universal changes for a very uncommon case. util/m5/m5ops.h <http://reviews.m5sim.org/r/64/#comment249> It looks like Ali commandeered that value on line 61. It might have been better to use 0x5A for that, but it also might not be safe to change it now since there may be binaries out there that use it (probably not too many). It would be a little strange, but you could actually use 0x5A for reserved1_func. I don't know what restrictions there are in the various ISAs for function numbers, but in x86 it's a 16 bit value. - Gabe On 2010-07-21 14:57:19, Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/64/ > ----------------------------------------------------------- > > (Updated 2010-07-21 14:57:19) > > > Review request for Default. > > > Summary > ------- > > util/m5/m5.c: in readfile(), added memset to touch all pages - ensure they > are in the page table > util/m5/m5ops/h: add reserved1_func back into list of magic ops > util/m5/Makefile.x86: should build the binary statically > > > Diffs > ----- > > util/m5/Makefile.x86 a75564db03c3 > util/m5/m5.c a75564db03c3 > util/m5/m5ops.h a75564db03c3 > > Diff: http://reviews.m5sim.org/r/64/diff > > > Testing > ------- > > > Thanks, > > Joel > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
