----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/192/#review271 -----------------------------------------------------------
src/arch/arm/faults.hh <http://reviews.m5sim.org/r/192/#comment406> Space after // in comments. I know it's not explicitly stated in the style guide, but the examples are consistent and it is what almost all other code does. We could update the style guide of course. In the future, to make life easier, I wouldn't mind having the rule that we follow the Google style guide when our style guide is silent. (I don't know the guide myself, but my guess is that it's decent). - Nathan On 2010-08-13 10:16:34, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/192/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:16:34) > > > Review request for Default. > > > Summary > ------- > > ARM: Make sure that software prefetch instructions can't change the state of > the TLB > > > Diffs > ----- > > src/arch/arm/faults.hh 3c48b2b3cb83 > src/arch/arm/table_walker.cc 3c48b2b3cb83 > src/arch/arm/tlb.cc 3c48b2b3cb83 > src/mem/cache/cache_impl.hh 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/192/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
