----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/365/#review618 -----------------------------------------------------------
It's pretty good. I think Nate's suggestion is great and maybe a little comment before each test "// Test setting variable to NULL lowers ref count" would be great. - Ali On 2011-01-03 12:56:11, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/365/ > ----------------------------------------------------------- > > (Updated 2011-01-03 12:56:11) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > RefCount: Add a unit test for reference counting pointers. > > This test exercises each of the functions in the reference counting pointer > implementation individually (except get()) and verifies they have some > minimially expected behavior. It also checks that reference counted objects > are freed when their usage count goes to 0 in some basic situations, > specifically a pointer being set to NULL and a pointer being deleted. > > > Diffs > ----- > > src/unittest/SConscript 3a790012d6ed > src/unittest/refcnttest.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/365/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
