So do we want to define a standard set of assert like macros/functions/whatever? If we're going to go for a fixed format we should stick that in a header somewhere. I went with asserts because they pretty conveniently check the result and blow up if there's a problem, but printing PASS/FAIL would be fine too.
Gabe Ali Saidi wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/365/ > > > It's pretty good. I think Nate's suggestion is great and maybe a little > comment before each test "// Test setting variable to NULL lowers ref count" > would be great. > > - Ali > > > On January 3rd, 2011, 12:56 p.m., Gabe Black wrote: > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, > and Nathan Binkert. > By Gabe Black. > > /Updated 2011-01-03 12:56:11/ > > > Description > > RefCount: Add a unit test for reference counting pointers. > > This test exercises each of the functions in the reference counting pointer > implementation individually (except get()) and verifies they have some > minimially expected behavior. It also checks that reference counted objects > are freed when their usage count goes to 0 in some basic situations, > specifically a pointer being set to NULL and a pointer being deleted. > > > Diffs > > * src/unittest/SConscript (3a790012d6ed) > * src/unittest/refcnttest.cc (PRE-CREATION) > > View Diff <http://reviews.m5sim.org/r/365/diff/> > > ------------------------------------------------------------------------ > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
