----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/383/#review640 -----------------------------------------------------------
There are a few problems with this. First, this is an indirect way to get around the problem. It looks like IntDev can be constructed with no latency argument which defaults to 0 which is why the call to sendTiming/schedule would fail. A better fix would be to pass the right latency to the constructor of IntDev so it has the right value as apposed to passing it in when needed (ignoring the stored value as well). Second, the latency being used in interrupts.cc is actually the pio_latency which is the latency for accessing the memory mapped registers in the local APIC. This is not necessarily the latency that should be used for sending interrupts. It looks like the IO APIC has an int_latency parameter, and it would make sense to put one on the local APIC too. Bringing it all around, that would then go to the IntDev constructor. - Gabe On 2011-01-06 15:56:44, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/383/ > ----------------------------------------------------------- > > (Updated 2011-01-06 15:56:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > IntDev: packet latency fix > > The IntDev should be responsible for setting the latency of packets sent > through it's port. This patch fixes the packet scheduling failure when the > IntPort latency is 0 in timing mode. > > > Diffs > ----- > > src/arch/x86/interrupts.cc 9f9e10967912 > src/dev/x86/i82094aa.cc 9f9e10967912 > src/dev/x86/intdev.hh 9f9e10967912 > src/dev/x86/intdev.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/383/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
