----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/384/#review641 -----------------------------------------------------------
See review of the earlier IntDev patch. Basically this is displacing the latency value from the base class that uses it into the subclass that gets it from the config. I don't think it's necessary as described previously, but also that decentralizes a value that's always used in the same place for the same purpose. - Gabe On 2011-01-06 15:57:01, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/384/ > ----------------------------------------------------------- > > (Updated 2011-01-06 15:57:01) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > IntDev: latency fix > > Since the device should be responsible for latency of packets, remove the > latency field of the IntPort completely. > > > Diffs > ----- > > src/dev/x86/intdev.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/384/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
