> On 2011-01-07 12:16:31, Nathan Binkert wrote: > > src/dev/x86/intdev.hh, line 62 > > <http://reviews.m5sim.org/r/384/diff/1/?file=9053#file9053line62> > > > > Just because something is not in the style guide doesn't mean it's not > > part of the style. I'd guess that 95% of m5 follows the convention. > > > > Style is hugely about consistency of code.
None of my code does, and that's a lot more than 5%. Grepping around suggests that neither does Korey's. I can go through and change it all to be my way if all that matters is consistency. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/384/#review661 ----------------------------------------------------------- On 2011-01-06 15:57:01, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/384/ > ----------------------------------------------------------- > > (Updated 2011-01-06 15:57:01) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > IntDev: latency fix > > Since the device should be responsible for latency of packets, remove the > latency field of the IntPort completely. > > > Diffs > ----- > > src/dev/x86/intdev.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/384/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
