> On 2011-01-08 10:41:35, Nilay Vaish wrote: > > src/base/statistics.hh, line 1514 > > <http://reviews.m5sim.org/r/357/diff/1/?file=5833#file5833line1514> > > > > This line seems to be incorrect. squares is being updated with > > val*val*number*number. Should it not be val*val*number?
Good catch. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/357/#review677 ----------------------------------------------------------- On 2010-12-21 11:15:24, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/357/ > ----------------------------------------------------------- > > (Updated 2010-12-21 11:15:24) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > stats: Add a histogram statistic type > > > Diffs > ----- > > src/base/statistics.hh 4a3bddd74f36 > src/base/statistics.cc 4a3bddd74f36 > src/base/stats/info.hh 4a3bddd74f36 > src/base/stats/text.cc 4a3bddd74f36 > src/unittest/stattest.cc 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/357/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
