----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/357/#review682 -----------------------------------------------------------
With each bucket, both the name and description of the histogram are printed. I think this is unnecessary. Should each bucket's count be printed in a new line? Again, seems unnecessary to me. - Nilay On 2010-12-21 11:15:24, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/357/ > ----------------------------------------------------------- > > (Updated 2010-12-21 11:15:24) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > stats: Add a histogram statistic type > > > Diffs > ----- > > src/base/statistics.hh 4a3bddd74f36 > src/base/statistics.cc 4a3bddd74f36 > src/base/stats/info.hh 4a3bddd74f36 > src/base/stats/text.cc 4a3bddd74f36 > src/unittest/stattest.cc 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/357/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
