-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/327/#review790
-----------------------------------------------------------



src/mem/ruby/system/Sequencer.cc
<http://reviews.m5sim.org/r/327/#comment1112>

    This is the portion of code that is not working correctly. If I compile 
this code, it works correctly with ruby random tester. But if I were to 
un-comment this line and comment out the one below, the code exits due to 
segmentation fault. In the debug mode, the code fails one of the assertion on 
the request type.


- Nilay


On 2011-01-20 14:06:16, Nilay Vaish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/327/
> -----------------------------------------------------------
> 
> (Updated 2011-01-20 14:06:16)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> The goal of the patch is to do away with the CacheMsg class currently in use 
> in coherence protocols. In place of CacheMsg, the RubyRequest class will 
> used. This class is already present in libruby.hh. In fact, objects of class 
> CacheMsg are generated by copying values from a RubyRequest object.
> 
> This is not complete as of yet. I am facing some difficulty in handling the 
> RefCountingPtr. To me it seems that I am creating the reference correctly. 
> So, the object gets deleted before all the references have gone out of scope.
> 
> 
> Diffs
> -----
> 
>   src/cpu/testers/rubytest/RubyTester.hh UNKNOWN 
>   src/mem/protocol/MOESI_hammer-cache.sm UNKNOWN 
>   src/mem/protocol/RubySlicc_Exports.sm UNKNOWN 
>   src/mem/protocol/RubySlicc_Profiler.sm UNKNOWN 
>   src/mem/protocol/RubySlicc_Types.sm UNKNOWN 
>   src/mem/ruby/SConscript UNKNOWN 
>   src/mem/ruby/common/Address.hh UNKNOWN 
>   src/mem/ruby/common/Address.cc UNKNOWN 
>   src/mem/ruby/common/DataBlock.hh UNKNOWN 
>   src/mem/ruby/common/DataBlock.cc UNKNOWN 
>   src/mem/ruby/filters/BlockBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/BulkBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/LSB_CountingBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/MultiGrainBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/NonCountingBloomFilter.cc UNKNOWN 
>   src/mem/ruby/libruby.hh UNKNOWN 
>   src/mem/ruby/libruby.cc UNKNOWN 
>   src/mem/ruby/libruby_internal.hh UNKNOWN 
>   src/mem/ruby/profiler/AccessTraceForAddress.cc UNKNOWN 
>   src/mem/ruby/profiler/AddressProfiler.hh UNKNOWN 
>   src/mem/ruby/profiler/AddressProfiler.cc UNKNOWN 
>   src/mem/ruby/profiler/Profiler.hh UNKNOWN 
>   src/mem/ruby/profiler/Profiler.cc UNKNOWN 
>   src/mem/ruby/recorder/CacheRecorder.hh UNKNOWN 
>   src/mem/ruby/recorder/CacheRecorder.cc UNKNOWN 
>   src/mem/ruby/recorder/TraceRecord.hh UNKNOWN 
>   src/mem/ruby/recorder/TraceRecord.cc UNKNOWN 
>   src/mem/ruby/recorder/Tracer.hh UNKNOWN 
>   src/mem/ruby/recorder/Tracer.cc UNKNOWN 
>   src/mem/ruby/slicc_interface/RubyRequest.hh PRE-CREATION 
>   src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.hh UNKNOWN 
>   src/mem/ruby/slicc_interface/RubySlicc_Util.hh UNKNOWN 
>   src/mem/ruby/slicc_interface/SConscript UNKNOWN 
>   src/mem/ruby/storebuffer/stb_interface.cc UNKNOWN 
>   src/mem/ruby/storebuffer/storebuffer.cc UNKNOWN 
>   src/mem/ruby/system/CacheMemory.hh UNKNOWN 
>   src/mem/ruby/system/CacheMemory.cc UNKNOWN 
>   src/mem/ruby/system/DMASequencer.hh UNKNOWN 
>   src/mem/ruby/system/DMASequencer.cc UNKNOWN 
>   src/mem/ruby/system/PerfectCacheMemory.hh UNKNOWN 
>   src/mem/ruby/system/RubyPort.hh UNKNOWN 
>   src/mem/ruby/system/RubyPort.cc UNKNOWN 
>   src/mem/ruby/system/Sequencer.hh UNKNOWN 
>   src/mem/ruby/system/Sequencer.cc UNKNOWN 
>   src/mem/ruby/system/SparseMemory.cc UNKNOWN 
>   src/mem/slicc/parser.py UNKNOWN 
> 
> Diff: http://reviews.m5sim.org/r/327/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilay
> 
>

_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to