> On 2011-01-20 15:49:13, Brad Beckmann wrote: > > I've only had a chance to briefly review this, but I do have a couple > > comments: - The hammer cache changes didn't seem to upload cleanly. Can you try to post them again? - I just want to confirm that the libruby interface is still useful to you all at Wisconsin, correct? I just want to make sure I understand why the libruby files exist after your change. Is it possible to eliminate at least a few of these functions? For example the libruby_init() function that takes a configuration file name as an argument?
Brad, The purpose of the patch is not to do away with libruby. I don't know what the purpose of libruby was. That's is why I have not ventured in to removing it. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/#review791 ----------------------------------------------------------- On 2011-01-21 05:03:54, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/327/ > ----------------------------------------------------------- > > (Updated 2011-01-21 05:03:54) > > > Review request for Default. > > > Summary > ------- > > The goal of the patch is to do away with the CacheMsg class currently in use > in coherence protocols. In place of CacheMsg, the RubyRequest class will > used. This class is already present in libruby.hh. In fact, objects of class > CacheMsg are generated by copying values from a RubyRequest object. > > This is not complete as of yet. I am facing some difficulty in handling the > RefCountingPtr. To me it seems that I am creating the reference correctly. > So, the object gets deleted before all the references have gone out of scope. > > > Diffs > ----- > > src/mem/ruby/recorder/Tracer.hh f84bfd45d607 > src/mem/ruby/recorder/Tracer.cc f84bfd45d607 > src/mem/ruby/slicc_interface/RubyRequest.hh PRE-CREATION > src/mem/ruby/recorder/TraceRecord.cc f84bfd45d607 > src/mem/ruby/profiler/Profiler.cc f84bfd45d607 > src/mem/ruby/recorder/CacheRecorder.hh f84bfd45d607 > src/mem/ruby/recorder/CacheRecorder.cc f84bfd45d607 > src/mem/ruby/recorder/TraceRecord.hh f84bfd45d607 > src/mem/ruby/profiler/AccessTraceForAddress.cc f84bfd45d607 > src/mem/ruby/profiler/AddressProfiler.hh f84bfd45d607 > src/mem/ruby/profiler/AddressProfiler.cc f84bfd45d607 > src/mem/ruby/profiler/Profiler.hh f84bfd45d607 > src/mem/ruby/libruby_internal.hh f84bfd45d607 > src/mem/ruby/libruby.cc f84bfd45d607 > src/mem/ruby/filters/LSB_CountingBloomFilter.cc f84bfd45d607 > src/mem/ruby/filters/MultiGrainBloomFilter.cc f84bfd45d607 > src/mem/ruby/filters/NonCountingBloomFilter.cc f84bfd45d607 > src/mem/ruby/libruby.hh f84bfd45d607 > src/mem/ruby/filters/BlockBloomFilter.cc f84bfd45d607 > src/mem/ruby/filters/BulkBloomFilter.cc f84bfd45d607 > src/mem/ruby/common/DataBlock.cc f84bfd45d607 > src/mem/ruby/common/DataBlock.hh f84bfd45d607 > src/mem/ruby/common/Address.cc f84bfd45d607 > src/mem/ruby/common/Address.hh f84bfd45d607 > src/mem/ruby/SConscript f84bfd45d607 > src/mem/protocol/RubySlicc_Types.sm f84bfd45d607 > src/mem/protocol/RubySlicc_Profiler.sm f84bfd45d607 > src/mem/protocol/RubySlicc_Exports.sm f84bfd45d607 > src/cpu/testers/rubytest/RubyTester.hh f84bfd45d607 > src/mem/protocol/MOESI_hammer-cache.sm f84bfd45d607 > src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.hh f84bfd45d607 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh f84bfd45d607 > src/mem/ruby/slicc_interface/SConscript f84bfd45d607 > src/mem/ruby/storebuffer/stb_interface.cc f84bfd45d607 > src/mem/ruby/storebuffer/storebuffer.cc f84bfd45d607 > src/mem/ruby/system/CacheMemory.hh f84bfd45d607 > src/mem/ruby/system/CacheMemory.cc f84bfd45d607 > src/mem/ruby/system/DMASequencer.hh f84bfd45d607 > src/mem/ruby/system/DMASequencer.cc f84bfd45d607 > src/mem/ruby/system/PerfectCacheMemory.hh f84bfd45d607 > src/mem/ruby/system/RubyPort.hh f84bfd45d607 > src/mem/ruby/system/RubyPort.cc f84bfd45d607 > src/mem/ruby/system/Sequencer.hh f84bfd45d607 > src/mem/ruby/system/Sequencer.cc f84bfd45d607 > src/mem/ruby/system/SparseMemory.cc f84bfd45d607 > src/mem/slicc/parser.py f84bfd45d607 > > Diff: http://reviews.m5sim.org/r/327/diff > > > Testing > ------- > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
