On 02/05/11 10:05, Steve Reinhardt wrote: > > !entry->writable && (inUser || cr0.wp) is used here and in the if below. > This would be easier to read if that was in a temporary variable, maybe > called badWrite. Nate would probably yell at me that it should be bad_write > because it's local. He'd be right, but that would be inconsistent with the > existing code. > > > If the inconsistency bothers you, then first fix all the other code > that's not following the style :-). > > Steve >
That's not a bad idea, but there's too much outstanding code right now. I wouldn't want to break patches and/or make merging difficult. I never really liked the local_variable rule and didn't even realize it existed for a long time, but rules are rules. Gabe
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
