> On 2011-02-11 19:44:42, Nathan Binkert wrote: > > Love it. Assuming that this compiles properly for *all* possible ISAs and > > emulations. Go for it. > > > > "M5:" is not particularly descriptive. Perhaps "includes:"?
I agree. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/481/#review844 ----------------------------------------------------------- On 2011-02-11 16:47:27, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/481/ > ----------------------------------------------------------- > > (Updated 2011-02-11 16:47:27) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > M5: Don't include isa_traits.hh and use the TheISA namespace unless really > needed. > > > Diffs > ----- > > src/dev/baddev.cc 6548721032fa > src/dev/platform.hh 6548721032fa > src/dev/platform.cc 6548721032fa > src/dev/simple_disk.hh 6548721032fa > src/mem/cache/blk.hh 6548721032fa > src/mem/cache/builder.cc 6548721032fa > src/mem/cache/prefetch/tagged.cc 6548721032fa > src/mem/physical.cc 6548721032fa > > Diff: http://reviews.m5sim.org/r/481/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
