There used to be builds that didn't have regressions. Is that not true anymore? Also, did you compile both fast and debug? This is the kind of thing that could bite you depending on how NDEBUG is set.
Nate > The regressions all run from a clean clone. Good enough? > > Ali > > Sent from my ARM powered device > > On Feb 12, 2011, at 1:20 AM, "Gabe Black" <gbl...@eecs.umich.edu> wrote: > > This is an automatically generated e-mail. To reply, visit: > <http://reviews.m5sim.org/r/481/>http://reviews.m5sim.org/r/481/ > > On February 11th, 2011, 7:44 p.m., *Nathan Binkert* wrote: > > Love it. Assuming that this compiles properly for *all* possible ISAs and > emulations. Go for it. > > "M5:" is not particularly descriptive. Perhaps "includes:"? > > I agree. > > > - Gabe > > On February 11th, 2011, 4:47 p.m., Ali Saidi wrote: > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > By Ali Saidi. > > *Updated 2011-02-11 16:47:27* > Description > > M5: Don't include isa_traits.hh and use the TheISA namespace unless really > needed. > > Diffs > > - src/dev/baddev.cc (6548721032fa) > - src/dev/platform.hh (6548721032fa) > - src/dev/platform.cc (6548721032fa) > - src/dev/simple_disk.hh (6548721032fa) > - src/mem/cache/blk.hh (6548721032fa) > - src/mem/cache/builder.cc (6548721032fa) > - src/mem/cache/prefetch/tagged.cc (6548721032fa) > - src/mem/physical.cc (6548721032fa) > > View Diff <http://reviews.m5sim.org/r/481/diff/> > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
