----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/#review875 -----------------------------------------------------------
src/mem/ruby/buffers/MessageBuffer.hh <http://reviews.m5sim.org/r/489/#comment1239> You have random whitespace here. Please remove it. src/mem/ruby/buffers/MessageBuffer.cc <http://reviews.m5sim.org/r/489/#comment1240> How does the name get set now? src/mem/ruby/buffers/MessageBuffer.cc <http://reviews.m5sim.org/r/489/#comment1245> no space after \n src/mem/ruby/network/simple/PerfectSwitch.hh <http://reviews.m5sim.org/r/489/#comment1241> use csprintf() src/mem/ruby/network/simple/Throttle.hh <http://reviews.m5sim.org/r/489/#comment1244> System includes before M5 includes src/mem/ruby/network/simple/Throttle.hh <http://reviews.m5sim.org/r/489/#comment1242> csprintf() src/mem/ruby/network/simple/Throttle.cc <http://reviews.m5sim.org/r/489/#comment1243> ccprintf() - Nathan On 2011-02-18 09:18:43, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/489/ > ----------------------------------------------------------- > > (Updated 2011-02-18 09:18:43) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: cleaning up RubyQueue and RubyNetwork dprintfs > Overall, continue to progress Ruby debug messages to more of the normal M5 > debug message style > - add a name() to the Ruby Throttle & PerfectSwitch objects so that the debug > output > isn't littered w/"global:" everywhere. > - clean up messages that print over multiple lines when possible > - clean up duplicate prints in the message buffer > > > Diffs > ----- > > src/mem/ruby/buffers/MessageBuffer.hh 42f772dc5a96 > src/mem/ruby/buffers/MessageBuffer.cc 42f772dc5a96 > src/mem/ruby/common/NetDest.hh 42f772dc5a96 > src/mem/ruby/network/simple/PerfectSwitch.hh 42f772dc5a96 > src/mem/ruby/network/simple/PerfectSwitch.cc 42f772dc5a96 > src/mem/ruby/network/simple/Throttle.hh 42f772dc5a96 > src/mem/ruby/network/simple/Throttle.cc 42f772dc5a96 > > Diff: http://reviews.m5sim.org/r/489/diff > > > Testing > ------- > > > Thanks, > > Korey > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
