----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/#review881 -----------------------------------------------------------
Ship it! - Brad On 2011-02-22 13:11:15, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/489/ > ----------------------------------------------------------- > > (Updated 2011-02-22 13:11:15) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: cleaning up RubyQueue and RubyNetwork dprintfs > Overall, continue to progress Ruby debug messages to more of the normal M5 > debug message style > - add a name() to the Ruby Throttle & PerfectSwitch objects so that the debug > output > isn't littered w/"global:" everywhere. > - clean up messages that print over multiple lines when possible > - clean up duplicate prints in the message buffer > > > Diffs > ----- > > src/mem/ruby/buffers/MessageBuffer.hh e6ce478c05d3 > src/mem/ruby/buffers/MessageBuffer.cc e6ce478c05d3 > src/mem/ruby/common/NetDest.hh e6ce478c05d3 > src/mem/ruby/network/simple/PerfectSwitch.hh e6ce478c05d3 > src/mem/ruby/network/simple/PerfectSwitch.cc e6ce478c05d3 > src/mem/ruby/network/simple/Throttle.hh e6ce478c05d3 > src/mem/ruby/network/simple/Throttle.cc e6ce478c05d3 > > Diff: http://reviews.m5sim.org/r/489/diff > > > Testing > ------- > > > Thanks, > > Korey > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
