-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/509/#review904
-----------------------------------------------------------
Ship it!
Looks good to me, other than the minor non-substantive change to the
assertions, and maybe some editing of the commit message ("losted"? also
"propagate" is spelled wrong)
src/cpu/o3/fetch_impl.hh
<http://reviews.m5sim.org/r/509/#comment1263>
This is minor, but I'd prefer to see these two asserts written as:
!(pkt->memInhibitAsserted() && !pkt->sharedAsserted())
because this explicitly asserts that we're not seeing the combination of
signals that indicates ownership, as opposed to having to apply De Morgan in
your head to figure that out :-)
- Steve
On 2011-02-25 21:04:34, Ali Saidi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/509/
> -----------------------------------------------------------
>
> (Updated 2011-02-25 21:04:34)
>
>
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and
> Nathan Binkert.
>
>
> Summary
> -------
>
> Mem: Fix issue with dirty block being losted when entire block transfered to
> non-cache.
>
> This change fixes the problem for all the cases we actively use. If you want
> to try
> more creative I/O device attachments (E.g. sharing an L2), this won't work.
> You
> would need another level of caching between the I/O device and the cache
> (which you actually need anyway with our current code to make sure writes
> propigate). This is required so that you can mark the cache inbetween as
> top level and it won't try to send ownership of a block to the I/O device.
> Asserts have been added that should catch any issues.
>
>
> Diffs
> -----
>
> configs/common/Caches.py 9dc17725f795
> src/cpu/o3/fetch_impl.hh 9dc17725f795
> src/dev/io_device.cc 9dc17725f795
> src/mem/cache/BaseCache.py 9dc17725f795
> src/mem/cache/base.hh 9dc17725f795
> src/mem/cache/base.cc 9dc17725f795
> src/mem/cache/cache_impl.hh 9dc17725f795
> tests/configs/inorder-timing.py 9dc17725f795
> tests/configs/memtest.py 9dc17725f795
> tests/configs/o3-timing-mp.py 9dc17725f795
> tests/configs/o3-timing.py 9dc17725f795
> tests/configs/pc-simple-atomic.py 9dc17725f795
> tests/configs/pc-simple-timing.py 9dc17725f795
> tests/configs/realview-simple-atomic.py 9dc17725f795
> tests/configs/realview-simple-timing.py 9dc17725f795
> tests/configs/simple-atomic-mp.py 9dc17725f795
> tests/configs/simple-timing-mp.py 9dc17725f795
> tests/configs/simple-timing.py 9dc17725f795
> tests/configs/tsunami-o3-dual.py 9dc17725f795
> tests/configs/tsunami-o3.py 9dc17725f795
> tests/configs/tsunami-simple-atomic-dual.py 9dc17725f795
> tests/configs/tsunami-simple-atomic.py 9dc17725f795
> tests/configs/tsunami-simple-timing-dual.py 9dc17725f795
> tests/configs/tsunami-simple-timing.py 9dc17725f795
>
> Diff: http://reviews.m5sim.org/r/509/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ali
>
>
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
