----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/570/#review943 -----------------------------------------------------------
src/cpu/o3/bpred_unit_impl.hh <http://reviews.m5sim.org/r/570/#comment1311> Does this snippet not do the same thing as the commented code below? Also, I'm wondering how this code worked before now, because this is the function called whenever a branch is resolved but formerly it only checked the most recent prediction. src/cpu/o3/bpred_unit_impl.hh <http://reviews.m5sim.org/r/570/#comment1312> Shouldn't we also just panic here since if this condition is true, the the simulation is pretty much broke right? - Korey On 2011-03-11 15:21:28, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/570/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:21:28) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Identify branches as conditional or unconditional and direct or > indirect. > > > Diffs > ----- > > src/arch/arm/insts/branch.hh 5138d1e453f1 > src/arch/arm/isa/insts/branch.isa 5138d1e453f1 > src/arch/arm/isa/templates/branch.isa 5138d1e453f1 > src/arch/arm/predecoder.hh 5138d1e453f1 > src/arch/arm/types.hh 5138d1e453f1 > src/cpu/o3/bpred_unit_impl.hh 5138d1e453f1 > > Diff: http://reviews.m5sim.org/r/570/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
