----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/578/#review960 -----------------------------------------------------------
I think this is a great change. There are only a couple small things to look at, and then of course making sure the regressions still work. I expect they will, but this touches a lot of areas so it's best to be sure. src/arch/mips/isa.hh <http://reviews.m5sim.org/r/578/#comment1337> Do you really want these to be static? Then they can't be changed between different CPUs which have separate ISA state. I can see how you might be treating them as constants, but I'm not familiar enough with MIPS to know if that makes sense. src/arch/mips/isa.cc <http://reviews.m5sim.org/r/578/#comment1338> This should be a panic, not an assert which will always be triggered. - Gabe On 2011-03-14 17:34:17, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/578/ > ----------------------------------------------------------- > > (Updated 2011-03-14 17:34:17) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > isa: get rid of expandForMT function > MIPS is the only ISA that cares about having a piece of ISA state integrate > multiple threads so add constants for MIPS and relieve the other ISAs from > having > to define this. Also, InOrder was the only core that was actively calling > this function > * * * > isa: get rid of corespecific type > The CoreSpecific type was used as a proxy to pass in HW specific params to > a MIPS CPU, but since MIPS FS hasnt been touched for awhile, it makes sense > to not force every other ISA to use CoreSpecific as well use a special > reset function to set it. That probably should go in a PowerOn reset fault > anyway. > > > Diffs > ----- > > src/arch/alpha/isa.hh 6c9b532da0a6 > src/arch/alpha/types.hh 6c9b532da0a6 > src/arch/arm/types.hh 6c9b532da0a6 > src/arch/mips/isa.hh 6c9b532da0a6 > src/arch/mips/isa.cc 6c9b532da0a6 > src/arch/power/types.hh 6c9b532da0a6 > src/arch/sparc/types.hh 6c9b532da0a6 > src/arch/x86/types.hh 6c9b532da0a6 > src/cpu/BaseCPU.py 6c9b532da0a6 > src/cpu/base.hh 6c9b532da0a6 > src/cpu/inorder/cpu.hh 6c9b532da0a6 > src/cpu/inorder/cpu.cc 6c9b532da0a6 > > Diff: http://reviews.m5sim.org/r/578/diff > > > Testing > ------- > > > Thanks, > > Korey > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
