----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/561/#review961 -----------------------------------------------------------
Hi Tushar, This patch basically looks done to me. I just have a few minor comments below. It seems that there are a few parameters that aren't used and should be removed. Also I think you should add a better explanation of the expected values for the injection rate. configs/example/ruby_network_test.py <http://reviews.m5sim.org/r/561/#comment1339> Why multiply by 1000? What is the expected range of injection rate? src/cpu/testers/networktest/NetworkTest.py <http://reviews.m5sim.org/r/561/#comment1343> Is this parameter used? If so, what does address to trace mean? src/cpu/testers/networktest/NetworkTest.py <http://reviews.m5sim.org/r/561/#comment1341> I think you can remove the functional port now, correct? src/cpu/testers/networktest/networktest.cc <http://reviews.m5sim.org/r/561/#comment1342> Again, I think you can remove the functional port. - Brad On 2011-03-15 01:14:34, Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/561/ > ----------------------------------------------------------- > > (Updated 2011-03-15 01:14:34) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, and Brad Beckmann. > > > Summary > ------- > > This patch adds the network tester for simple and garnet networks. > The tester code is in testers/networktest. > The tester can be invoked by configs/example/ruby_network_test.py. > A dummy coherence protocol called Network_test is also addded for > network-only simulations and testing. The protocol takes in messages from the > tester and just pushes them into the network in the appropriate vnet, without > storing any state. > > > Diffs > ----- > > build_opts/ALPHA_SE_Network_test PRE-CREATION > configs/example/ruby_network_test.py PRE-CREATION > configs/ruby/Network_test.py PRE-CREATION > src/cpu/testers/networktest/NetworkTest.py PRE-CREATION > src/cpu/testers/networktest/SConscript PRE-CREATION > src/cpu/testers/networktest/networktest.hh PRE-CREATION > src/cpu/testers/networktest/networktest.cc PRE-CREATION > src/mem/protocol/Network_test-cache.sm PRE-CREATION > src/mem/protocol/Network_test-dir.sm PRE-CREATION > src/mem/protocol/Network_test-msg.sm PRE-CREATION > src/mem/protocol/Network_test.slicc PRE-CREATION > src/mem/protocol/SConsopts 6c9b532da0a6 > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 6c9b532da0a6 > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 6c9b532da0a6 > src/mem/ruby/network/garnet/BaseGarnetNetwork.py 6c9b532da0a6 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 6c9b532da0a6 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 6c9b532da0a6 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 6c9b532da0a6 > src/mem/ruby/system/Sequencer.hh 6c9b532da0a6 > src/mem/ruby/system/Sequencer.cc 6c9b532da0a6 > src/mem/ruby/system/Sequencer.py 6c9b532da0a6 > > Diff: http://reviews.m5sim.org/r/561/diff > > > Testing > ------- > > Testing done with garnet and simple networks. I will update config > assumptions etc on the wiki. > > > Thanks, > > Tushar > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
