----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/561/ -----------------------------------------------------------
(Updated 2011-03-20 05:11:37.330118) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert, and Brad Beckmann. Changes ------- - Addressed Brad's comments: (1) removed functional ports from testers/networktest; (2) added a precision option to ruby_network_test.py that specifies the number of digits of precision after the decimal point for the injection rate. Also added comment to explain injection rate range. This field is used by networktest.cc when deciding whether or not to generate a packet. [Earlier this precision was hard-coded to 3 digits] - Updated the Network_test-cache.sm file to replace CacheRequestType to RubyRequestType in accordance with recent m5 changes. Summary ------- This patch adds the network tester for simple and garnet networks. The tester code is in testers/networktest. The tester can be invoked by configs/example/ruby_network_test.py. A dummy coherence protocol called Network_test is also addded for network-only simulations and testing. The protocol takes in messages from the tester and just pushes them into the network in the appropriate vnet, without storing any state. Diffs (updated) ----- build_opts/ALPHA_SE_Network_test PRE-CREATION configs/example/ruby_network_test.py PRE-CREATION configs/ruby/Network_test.py PRE-CREATION src/cpu/testers/networktest/NetworkTest.py PRE-CREATION src/cpu/testers/networktest/SConscript PRE-CREATION src/cpu/testers/networktest/networktest.hh PRE-CREATION src/cpu/testers/networktest/networktest.cc PRE-CREATION src/mem/protocol/Network_test-cache.sm PRE-CREATION src/mem/protocol/Network_test-dir.sm PRE-CREATION src/mem/protocol/Network_test-msg.sm PRE-CREATION src/mem/protocol/Network_test.slicc PRE-CREATION src/mem/protocol/SConsopts 89cd8302abd3 src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 89cd8302abd3 src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 89cd8302abd3 src/mem/ruby/network/garnet/BaseGarnetNetwork.py 89cd8302abd3 src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 89cd8302abd3 src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc 89cd8302abd3 src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc 89cd8302abd3 src/mem/ruby/system/Sequencer.hh 89cd8302abd3 src/mem/ruby/system/Sequencer.cc 89cd8302abd3 src/mem/ruby/system/Sequencer.py 89cd8302abd3 Diff: http://reviews.m5sim.org/r/561/diff Testing ------- Testing done with garnet and simple networks. I will update config assumptions etc on the wiki. Thanks, Tushar _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev