On Wed, Aug 13, 2008 at 1:43 AM, Olga Natkovich <[EMAIL PROTECTED]> wrote: > Hi, > > Thanks for quick feedback! A couple of follow up questions inline. > >> -----Original Message----- >> From: ant elder [mailto:[EMAIL PROTECTED] >> Sent: Tuesday, August 12, 2008 12:07 AM >> To: general@incubator.apache.org >> Subject: Re: [VOTE] Release Apache Pig 0.1.0-incubating >> >> On Mon, Aug 11, 2008 at 7:26 PM, Olga Natkovich >> <[EMAIL PROTECTED]> wrote: >> >> > Hi Everyone, >> > >> > Apache Pig dev community voted to release Pig >> 0.1.0-incubating. We had >> > 4 >> > +1 votes from committers and mentors and no 0 or -1 votes. >> (Message-ID: >> > >> <[EMAIL PROTECTED] >> > >) >> > . >> > >> > The artifacts are available at >> > >> http://people.apache.org/~olga/pig-0.1.0-candidate-4/<http://people.ap >> > ache.org/%7Eolga/pig-0.1.0-candidate-4/> >> > >> <http://people.apache.org/~olga/pig-0.1.0-candidate-4/<http://people.a >> > pache.org/%7Eolga/pig-0.1.0-candidate-4/> >> > > >> > >> > Please vote by 6 pm on Thursday, 8/14. >> > >> > Olga >> > >> > >> >> The main issue is the NOTICE file is missing some copyrights >> for the 3rd party products that are included such as javacc, >> jsch, and jetty (jetty is embedded within the >> pig-0.1.0-incubating-core.jar). I think this should be fixed >> for this release. > > I put the licenses in separate files in the lib directory where all the > 3rd party libraries are following Hadoop model. I did not realize that > they had to go to the notice file. I can move them if needed. Also jetty > is part of Hadoop distribution; is it sufficient just to have Hadoop > license present? > >> >> Some other comments: >> >> If the pig-0.1.0-incubating-core.jar is to be distributed >> separately (eg maven repo) then it needs to include >> LICENSE/NOTICE/DISCLAIMER files. > > What is the DISCLAIMER file?
The disclaimer is what you have at the bottom of your README.txt: http://svn.apache.org/repos/asf/incubator/pig/branches/branch-0.1/README.txt Other podlings put that in a file called "DISCLAIMER" - for example: http://svn.apache.org/repos/asf/incubator/qpid/tags/M2.1/RC6/DISCLAIMER I looked to see if there was any docs on this - they look like a work in progress but - according to those it looks like what you have is OK: http://incubator.apache.org/guides/releasemanagement.html#notes-disclaimer Niall >> The signature used to sign the distribution isn't available >> online from a public key server, eg pgp.surfnet.nl > > Keys are at /www/www.apache.org/dist/incubator/pig on people.apache.org. > Is this not the right location? > >> The release should be built from an svn tag but there doesn't >> seem to be one. > > I created a branch for it. Will add a tag as well. > >> Would be helpful to include a RAT report in the VOTE email > > Attached now > >> >> Other than that it looks good, if the NOTICE file is updated >> it would get my >> +1. >> >> ...ant >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
