On 12 May 2009, at 00:24, sebb wrote:
Some NOTICE files start with:
=
=
=
======================================================================
== NOTICE file corresponding to the section 4 d
of ==
== the Apache License, Version
2.0, ==
== in this case for the Apache Shindig
distribution. ==
=
=
=
======================================================================
This is wrong, it should start with the text as described here:
http://www.apache.org/legal/src-headers.html#notice
ok, will fix.
The top-level NOTICE file (and java/NOTICE) also contains details of
the crypto requirements.
These are supposed to be in a README file, see:
http://www.apache.org/dev/crypto.html#inform
will fix.
NOTICE mentions opensocial-resources, PHPUnit and Zend, but
LICENSE mentions PHPUnit, Zend and jsmin.php.
I would expect LICENSE to include a mention of opensocial-resources
NOTICE should probably have a mention of jsmin.php
will fix, verifying the exact license text of the OpenSocial Resources
at the moment.
Release archives
----------------
There is no need for .asc.md5 and .asc.sha1 hashes; delete them before
deployment
Ok will do.
Binary archives
===============
The war file contains lots of 3rd party libraries.
None of these are mentioned in the NOTICE or LICENCE files.
I was reliably informed that this was discussed on the Maven list in
March 2008 (subject: legal-discuss) and for binary distributions that
are created by the war packager that contained 3rd party libraries the
DEPENDENCIES file was sufficient to comply with ASF rules.
For source distributions, if any were bundled, they would require
mention in NOTICE or LICENSE in the appropriate form, but AFAIK, there
are no 3rd party libraries included that are not in those files.
please advise on this one.
The N & L files in the java jar files are mostly OK, except
java-features has an incorrect NOTICE file.
Source archives
===============
The tgz and zip files have the same files as each other, and the same
files as SVN.
However, most of the files in the archives are different from the
files in SVN.
The source files have additional empty lines at the end, and the PNG
files are unusable.
There's clearly something wrong with the way the files have been added
to the archives.
Will fix, thanks for spotting this one.
README.svn has 3 spelling mistakes:
6: supliment => supplement
15,29: it's => its
I've not tried building or testing the release
Will fix.
Thanks for reviewing,
Sorry to have brought this to the PMC with these errors.
First releases are liable to have problems but thank you for you
continuing patience.
Ian
On 11/05/2009, Ian Boston <i...@tfd.co.uk> wrote:
On 11 May 2009, at 18:11, sebb wrote:
On 11/05/2009, Ian Boston <i...@tfd.co.uk> wrote:
Hi,
Please review and vote on approving the first release of Apache
Shindig version 1.0-incubating.
Apache Incubator Shindig is a JavaScript container and
implementations
of the backend APIs and proxy required for hosting OpenSocial
applications.
Vote Thread.
http://markmail.org/message/ncwat7aiyfkxq6jf
Proposed release:
https://repository.apache.org/content/repositories/shindig-staging-013/
Binaries:
https://repository.apache.org/content/repositories/shindig-staging-013/
org/apache/shindig/shindig/1.0-incubating/
SVN Tag:
https://svn.apache.org/repos/asf/incubator/shindig/tags/shindig-project-1.0-incubating/
I see you have reused the same SVN tag as in the previous vote.
Tags are supposed to be immutable.
How are we to know which particular version of the tag really
relates
to the archives?
Please can you provide at least the svn revision of the tag, so
people
can check that they are voting on the same items.
From the commit log
The Tag was created at revision 772601 on at Thu May 7 10:45:55
2009 GMT
verification of the tag version can be found here
http://svn.apache.org/viewvc/incubator/shindig/tags/shindig-project-1.0-incubating/
Ian
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
Thanks,
Ian
---------------------------------------------------------------------
To unsubscribe, e-mail:
general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail:
general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail:
general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
