On 31/05/2009, Gurkan Erdogdu <gurkanerdo...@yahoo.com> wrote: > > > >>The .asc.md5 and .asc.sha1 hashes should be deleted as they serve no > purpose. > > >>The POM files in the source archives have the wrong version; they are > using > >>1.0.0-incubating-SNAPSHOT whereas they should have > >>1.0.0-incubating-M2 > > >>This is a release blocker. Looks like the artifacts were built from > >>the wrong SVN checkout. > > OK, I will correct those. > > >>>There are some major problems with the NOTICE and LICENSE files. > > When we created these file, we got help from our mentors. So we corrected > those files in the M1 release repeatedly. If you look at the for example, > Geronimo NOTICE file, it really like to OWB. I attached Geronimo NOTICE > file for example.
I'm afraid that NOTICE file is wrong as well. See: http://www.apache.org/dev/release.html#notice-content and http://apache.org/legal/src-headers.html#notice http://apache.org/legal/src-headers.html#faq-examplenotice > We have included "*licenses*" folder to hold third party license texts to > ease reading of the third party licenses. Is it really necessary to put all > of these text lines into the LICENCE text? Is it really block release? > Yes, the user must be able to find all the licences by checking the LICENSE file. See: http://www.apache.org/dev/release.html#distributing-code-under-several-licenses > Thanks; > > --- Gurkan > > > ________________________________ > From: sebb <seb...@gmail.com> > To: general@incubator.apache.org > Sent: Saturday, May 30, 2009 2:36:12 PM > Subject: Re: [VOTE] Release OpenWebBeans 1.0.0-incubating-M2 > > On 26/05/2009, Gurkan Erdogdu <gurkanerdo...@yahoo.com> wrote: > > Hi; > > > > OpenWebBeans will be an ASL-licensed implementation of the Web Beans > Specification which is defined as JSR-299. > > > > Proposed released artifacts are: > > > > Plugins repository > > -------------------------- > > > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M2/plugins/org/apache/openwebbeans > > I've not checked these. > > > Distribution content > > ---------------------------- > > > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M2/ > > The .asc.md5 and .asc.sha1 hashes should be deleted as they serve no > purpose. > > The POM files in the source archives have the wrong version; they are using > 1.0.0-incubating-SNAPSHOT whereas they should have > 1.0.0-incubating-M2 > > This is a release blocker. Looks like the artifacts were built from > the wrong SVN checkout. > > The source archives have an additional top-level src/ directory which > is not usual. > > Normally this is included in the parent, e.g. > > apache-openwebbeans-distribution-1.0.0-incubating-M2-src > > rather than > > apache-openwebbeans-distribution-1.0.0-incubating-M2/src > > This is not a release-blocker. > > > SVN Tag > > ---------------------------- > > > http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M2/ > > There are some major problems with the NOTICE and LICENSE files. > > The NOTICE file must start with: > > Apache OpenWebBeans > Copyright 2008, 2009 The Apache Software Foundation > > The preceeding 4 lines need to be removed. > Also, the NOTICE file is much too long, it should be used for required > elements only, so remove any references to other ASF projects and all > the headers enclosed in == > > Some of the other entries include too much data. > > The LICENSES file only contains the Apache License. It must contain > all the required licenses. > > These are both release blockers. > > There is at least one file in SVN with inconsistent line-endings: > > svn pl -v openwebbeans-1.0.0-incubating-M2/samples/guess > Properties on > 'openwebbeans-1.0.0-incubating-M2\samples\guess': > svn: Inconsistent line ending style > > It looks like the svn:eol-style properties are missing from a lot of files. > > This makes it difficult to use the code except on OSes with the same > EOL as the file happens to be. > > This ought to be fixed before creating any new tags, because the tags > cannot be fixed later. > > > The release vote on the openwebbeans-dev mailing list resulted in three > +1 > > votes and no 0 or -1 votes from podling PMC members. > > My vote is -1, based on the problems with the N & L files, and the > incorrect version in the pom.xml > > > [VOTES] > > Kevan Miller +1 Binding (PPMC) > > Gurkan Erdogdu +1 (PPMC) > > Mark Struberg +1 (PPMC) > > > > [VOTE Thread] : > http://www.mail-archive.com/openwebbeans-...@incubator.apache.org/msg00944.html > > > > More information about the project can be found here: > > [Incubation Status Page ] : > http://incubator.apache.org/projects/openwebbeans.html > > [Project Page] : > http://incubator.apache.org/openwebbeans/1.0.0-SNAPSHOT/index.html > > [Wiki Page] : http://cwiki.apache.org/OWB/ > > [Blog] : http://blogs.apache.org/OWB/ > > > > Thanks; > > > > > > Gurkan Erdogdu > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > general-unsubscr...@incubator.apache.org > For additional commands, e-mail: > general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > general-unsubscr...@incubator.apache.org > For additional commands, e-mail: > general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
