The RAT report after these changes looks good except for two files, which come from the skins in the site:
[rat:report] Unapproved licenses: [rat:report] [rat:report] C:/wip/mcf-release/release-0.1-branch/site/src/documentation/skins/common/xslt/html/split.xsl [rat:report] C:/wip/mcf-release/release-0.1-branch/site/src/documentation/skins/lucene/note.txt [rat:report] [rat:report] ******************************* One of these looks like it comes from Forrest itself (the first), and has this header: <!-- This stylesheet was taken from the XSLT FAQ http://www.dpawson.co.uk/xsl/ Comments and adaption to be used without normalize-space() by forrest-...@xml.apache.org --> No idea what to do about that one. The other is merely a "todo" list in the Lucene skin, which I believe could simply be removed. Thoughts? Karl On Thu, Jan 6, 2011 at 8:26 PM, Karl Wright <daddy...@gmail.com> wrote: > They were downloaded from the jakarta standard taglibs 1.1.2, from this URL: > > http://jakarta.apache.org/site/downloads/downloads_taglibs-standard.cgi > > The project was folded into tomcat, but I simply used the tag > libraries from the separately-bundled artifact. It turns out that the > Apache headers were not on it, however, although it seems very clear > that these *should* have apache headers on them. > > I'm happy to just go ahead and do that, unless you think it would be a > mistake. > > Karl > > On Thu, Jan 6, 2011 at 8:13 PM, sebb <seb...@gmail.com> wrote: >> On 6 January 2011 23:53, Karl Wright <daddy...@gmail.com> wrote: >>> The .cs files are maintained by Visual Studio and you cannot change >>> the format if you want them to keep working. Same with the .map file. >>> I will add them to exclusions for the rat target >>> >>> The .tld's were taken from Apache Tomcat, but did not include Apache >>> headers. I am not sure what I should do with those, which is why I >>> left them as is. What is your recommendation? >> >> Depends on the source. If they are ASF files then they should have ASF >> headers in Tomcat and here. >> If not, then they may require entries in NOTICE or LICENSE. >> Probably best to re-check the Tomcat sources, and if there is no >> header, ask why on the Tomcat list. >> >>> Karl >>> >>> >>> >>> On Thu, Jan 6, 2011 at 6:26 PM, sebb <seb...@gmail.com> wrote: >>>> On 6 January 2011 22:38, Karl Wright <daddy...@gmail.com> wrote: >>>>> We've been using the RAT tool. >>>> >>>> In which case it would be helpful to provide the RAT report(s). >>>> >>>>> The files without headers are in part >>>>> Microsoft project files, which cannot have headers added without >>>>> breaking them. Also, we build JSON sources, which are licensed with >>>>> an accepted JSON license that RAT does not recognize. >>>>> >>>>> I've captured a lot of these exceptions in the ant target "rat-sources". >>>>> >>>>> Karl >>>>> >>>>> If you have specific concerns, let's discuss them. >>>> >>>> The following sources don't appear to be JSON files, yet they don't >>>> have AL headers: >>>> >>>> framework/crawler-ui/src/main/webapp/WEB-INF/jsp/x.tld >>>> framework/crawler-ui/src/main/webapp/WEB-INF/jsp/sql.tld >>>> framework/crawler-ui/src/main/webapp/WEB-INF/jsp/fmt.tld >>>> framework/crawler-ui/src/main/webapp/WEB-INF/jsp/c.tld >>>> connectors/sharepoint/webservice/Web >>>> References/SPPermissionsService/Reference.map >>>> connectors/sharepoint/webservice/Properties/Settings.settings >>>> connectors/sharepoint/webservice/Properties/AssemblyInfo.cs >>>> connectors/meridio/webservice/Test Harness/source code/TestHarness.cs >>>> >>>> AFAICT these are not excluded by the Ant target. >>>> >>>> BTW some of the .cs files appear to have BOM markers - not sure >>>> whether that is intentional. >>>> >>>>> On Thu, Jan 6, 2011 at 4:03 PM, sebb <seb...@gmail.com> wrote: >>>>>> Just noticed that there are a lot of source files without AL headers. >>>>>> The RAT tool can detect these for you. >>>>>> >>>>>> Also, there should normally be a DISCLAIMER file at the top-level of >>>>>> archives and SVN trees. >>>>>> >>>>>> It's simpler to have this in a separate file, which can then just be >>>>>> deleted upon graduation. >>>>>> >>>>>> On 6 January 2011 13:12, Grant Ingersoll <gsing...@apache.org> wrote: >>>>>>> Hi, >>>>>>> >>>>>>> The Apache ManifoldCF community has voted to release our first set of >>>>>>> artifacts and now would like an Incubator vote. Since this is our >>>>>>> first release, extra attention to detail is appreciated. >>>>>>> >>>>>>> You can find the artifacts at http://people.apache.org/~kwright/ >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Grant >>>>>>> >>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>>>> >>>>>>> >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
