On 6/14/2011 8:14 PM, Marvin Humphrey wrote:
O

There should be archived VOTE threads on the droids-private list, which were
cc'd to private@incubator.a.o.  Hopefully they were for PPMC membership.  If
not, there will be some cleanup work to do.


The votes were handled on the droids-dev list (like they should) and were committer votes. So Bertil and I aren't on the PPMC.


Excellent.  Was your work documented anywhere?  Ideally, there would be a JIRA
issue I can read over explaining why each dependency with a non-category-A
license is OK.

     http://www.apache.org/legal/resolved.html


No, there is no JIRA ticket. There are no category-X defined dependencies. The notice file includes notices for all the category B defined dependencies: JUnit and javax.servlet. Those are fairly common in Apache projects and the requirements were met. See below.

Attached is the dependency hierarchy. All of the Apache projects are full projects, so they are all good. That leaves:

NekoHTML - AL2
SLF4J - MIT
mockito - MIT
Google Guava - AL2
Spring - AL2
JUnit - CPL v1 - Category B, binary only, appropriately labeled in the NOTICE.txt file javax.servlet - Included in the Jetty notice, which states it is CDDLv1 and copyright Sun Microsystems and ASF. Notice text copied from Solr
Jetty 6 - AL2, but requires notice (in place)
CGLib - AL2



Further help and guidance of course is always welcome.
You are gracious.  I'll defer to others on guidance; I see my role as more
that of a QC engineer.

And to start off my QC, I'll note that there are some oddities in the top
level directory of the archive.  Here's the file list:

     DEPENDENCIES
     LICENSE
     LICENSE.txt
     NOTICE
     NOTICE.txt
     README.TXT
     droids-core
     droids-norobots
     droids-solr
     droids-spring
     droids-tika
     droids-wicket
     pom.xml

The LICENSE and LICENSE.txt files are essentially duplicates of each other,
having only whitespace differences.  However, the NOTICE and NOTICE.txt files
are quite distinct (diff below my sig).  I think this is a blocker.


That's Maven. LICENSE.txt and NOTICE.txt are the two in svn. We may need to rename them to be without the .txt so Maven doesn't do its own thing there. While without txt is preferred, it is allowable to use the .txt file names.

I'm not sure what the DEPENDENCIES file is supposed to tell us, but it contains
minimal information.  Presumably it's some Maven thing I just don't grok.

That was Maven generated and I don't understand it either. I used the defined method of releasing via Apache Maven, including using the latest parent pom.

Lastly, I think it's worth commenting on the contents of README.TXT, which
starts off like so:

                         A p a c h e    D r o i d s
                         --------------------------

                by Thorsten Scherler<thorsten at apache.org>

That credit is obviously inaccurate and seems quite unusual for an Apache
project.  I know that other projects have gone out of their way to delete all
@author tags.  Perhaps Droids might consider doing likewise.

Yes, that file needs to be cleaned up. I do see there are two source files with @author in them. I've fixed them in trunk. I don't think either of these two things are a blocker.

I also intend to run a RAT report, and to pore over LICENSE and NOTICE more
thoroughly, but I'm out of time for today and wanted to get you this feedback
sooner rather than later.


Thanks for the feedback. I poured over the LICENSE.txt and NOTICE.txt files quite carefully. The RAT report was ran until it came back clean twice. Those should be good.
 org.apache.droids:droids-core:jar:0.1
 +- org.apache.droids:droids-norobots:jar:0.1:compile
 +- commons-logging:commons-logging:jar:1.1.1:compile
 +- org.apache.httpcomponents:httpclient:jar:4.0.1:compile
 |  +- org.apache.httpcomponents:httpcore:jar:4.0.1:compile
 |  \- commons-codec:commons-codec:jar:1.3:compile
 +- net.sourceforge.nekohtml:nekohtml:jar:1.9.14:compile
 |  \- xerces:xercesImpl:jar:2.9.1:compile
 +- com.google.guava:guava:jar:r07:compile
 +- org.slf4j:slf4j-api:jar:1.6.1:compile
 +- junit:junit:jar:4.5:test
 +- org.mockito:mockito-all:jar:1.8.5:test
 \- org.slf4j:slf4j-simple:jar:1.6.1:test



 org.apache.droids:droids-spring:jar:0.1
 +- org.apache.droids:droids-core:jar:0.1:compile
 |  +- org.apache.droids:droids-norobots:jar:0.1:compile
 |  +- org.apache.httpcomponents:httpclient:jar:4.0.1:compile
 |  |  +- org.apache.httpcomponents:httpcore:jar:4.0.1:compile
 |  |  \- commons-codec:commons-codec:jar:1.3:compile
 |  +- net.sourceforge.nekohtml:nekohtml:jar:1.9.14:compile
 |  |  \- xerces:xercesImpl:jar:2.9.1:compile
 |  +- com.google.guava:guava:jar:r07:compile
 |  \- org.slf4j:slf4j-api:jar:1.6.1:compile
 +- commons-logging:commons-logging:jar:1.1.1:compile
 +- org.apache.cocoon:cocoon-spring-configurator:jar:2.0.0:compile
 |  +- org.apache.cocoon:cocoon-configuration-api:jar:1.0.2:compile
 |  +- commons-io:commons-io:jar:1.4:compile (version managed from 1.3.1)
 |  +- org.springframework:spring-core:jar:2.5.5:compile
 |  +- org.springframework:spring-context:jar:2.5.5:compile
 |  |  \- aopalliance:aopalliance:jar:1.0:compile
 |  +- org.springframework:spring-beans:jar:2.5.5:compile
 |  +- org.springframework:spring-aop:jar:2.5.5:compile
 |  \- org.springframework:spring-web:jar:2.5.5:compile
 +- junit:junit:jar:4.5:test
 \- org.apache.droids:droids-core:test-jar:tests:0.1:test


 org.apache.droids:droids-solr:jar:0.1
 +- org.apache.droids:droids-core:jar:0.1:compile
 |  +- org.apache.droids:droids-norobots:jar:0.1:compile
 |  +- commons-logging:commons-logging:jar:1.1.1:compile
 |  +- org.apache.httpcomponents:httpclient:jar:4.0.1:compile
 |  |  \- org.apache.httpcomponents:httpcore:jar:4.0.1:compile
 |  \- com.google.guava:guava:jar:r07:compile
 +- net.sourceforge.nekohtml:nekohtml:jar:1.9.14:compile
 |  \- xerces:xercesImpl:jar:2.9.1:compile
 +- org.apache.solr:solr-solrj:jar:1.3.0:compile
 |  +- org.apache.solr:solr-common:jar:1.3.0:compile
 |  +- commons-httpclient:commons-httpclient:jar:3.1:compile
 |  +- commons-codec:commons-codec:jar:1.3:compile
 |  +- org.apache.commons:commons-io:jar:1.3.2:compile
 |  +- commons-fileupload:commons-fileupload:jar:1.2:compile
 |  +- stax:stax:jar:1.2.0:compile
 |  +- stax:stax-api:jar:1.0.1:compile
 |  \- net.java.dev.stax-utils:stax-utils:jar:20040917:compile
 +- org.apache.solr:solr-core:jar:1.3.0:test
 |  +- org.apache.solr:solr-lucene-analyzers:jar:1.3.0:test
 |  |  \- org.apache.solr:solr-lucene-core:jar:1.3.0:test
 |  +- org.apache.solr:solr-lucene-highlighter:jar:1.3.0:test
 |  +- org.apache.solr:solr-lucene-queries:jar:1.3.0:test
 |  +- org.apache.solr:solr-lucene-snowball:jar:1.3.0:test
 |  +- org.apache.solr:solr-lucene-spellchecker:jar:1.3.0:test
 |  +- org.apache.solr:solr-commons-csv:jar:1.3.0:test
 |  +- woodstox:wstx-asl:jar:3.2.7:test
 |  \- org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:test
 +- log4j:log4j:jar:1.2.14:test
 +- javax.servlet:servlet-api:jar:2.3:test
 +- org.slf4j:slf4j-api:jar:1.4.2:compile
 +- org.slf4j:slf4j-log4j12:jar:1.4.2:test
 \- junit:junit:jar:4.5:test


 org.apache.droids:droids-tika:jar:0.1
 +- junit:junit:jar:4.5:test
 +- org.apache.droids:droids-core:jar:0.1:compile
 |  +- org.apache.droids:droids-norobots:jar:0.1:compile
 |  +- commons-logging:commons-logging:jar:1.1.1:compile
 |  +- org.apache.httpcomponents:httpclient:jar:4.0.1:compile
 |  |  +- org.apache.httpcomponents:httpcore:jar:4.0.1:compile
 |  |  \- commons-codec:commons-codec:jar:1.3:compile
 |  +- net.sourceforge.nekohtml:nekohtml:jar:1.9.14:compile
 |  |  \- xerces:xercesImpl:jar:2.9.1:compile
 |  +- com.google.guava:guava:jar:r07:compile
 |  \- org.slf4j:slf4j-api:jar:1.6.1:compile
 +- org.apache.tika:tika-core:jar:0.6:compile
 \- org.apache.tika:tika-parsers:jar:0.6:compile
    +- org.apache.commons:commons-compress:jar:1.0:compile
    +- org.apache.pdfbox:pdfbox:jar:0.8.0-incubating:compile
    |  +- org.apache.pdfbox:fontbox:jar:0.8.0-incubator:compile
    |  \- org.apache.pdfbox:jempbox:jar:0.8.0-incubator:compile
    +- org.apache.poi:poi:jar:3.6:compile
    +- org.apache.poi:poi-scratchpad:jar:3.6:compile
    +- org.apache.poi:poi-ooxml:jar:3.6:compile
    |  +- org.apache.poi:poi-ooxml-schemas:jar:3.6:compile
    |  |  \- org.apache.xmlbeans:xmlbeans:jar:2.3.0:compile
    |  \- dom4j:dom4j:jar:1.6.1:compile
    |     \- xml-apis:xml-apis:jar:1.0.b2:compile
    +- org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:compile
    +- org.ccil.cowan.tagsoup:tagsoup:jar:1.2:compile
    +- asm:asm:jar:3.1:compile
    +- log4j:log4j:jar:1.2.14:compile
    \- com.drewnoakes:metadata-extractor:jar:2.4.0-beta-1:compile

 org.apache.droids:droids-wicket:jar:0.1
 +- org.apache.droids:droids-core:jar:0.1:compile
 |  +- org.apache.droids:droids-norobots:jar:0.1:compile
 |  +- commons-logging:commons-logging:jar:1.1.1:compile
 |  +- org.apache.httpcomponents:httpclient:jar:4.0.1:compile
 |  |  +- org.apache.httpcomponents:httpcore:jar:4.0.1:compile
 |  |  \- commons-codec:commons-codec:jar:1.3:compile
 |  +- net.sourceforge.nekohtml:nekohtml:jar:1.9.14:compile
 |  |  \- xerces:xercesImpl:jar:2.9.1:compile
 |  \- com.google.guava:guava:jar:r07:compile
 +- org.apache.wicket:wicket:jar:1.4-rc1:compile
 +- org.apache.wicket:wicket-extensions:jar:1.4-rc1:compile
 +- org.apache.wicket:wicket-spring:jar:1.4-rc1:compile
 |  +- org.apache.wicket:wicket-ioc:jar:1.4-rc1:compile
 |  |  \- cglib:cglib-nodep:jar:2.1_3:compile
 |  \- org.springframework:spring:jar:2.0:compile
 +- commons-beanutils:commons-beanutils:jar:1.8.0:compile
 +- commons-lang:commons-lang:jar:2.4:compile
 +- org.slf4j:slf4j-api:jar:1.6.1:compile
 +- org.slf4j:slf4j-log4j12:jar:1.6.1:compile
 +- log4j:log4j:jar:1.2.9:compile
 +- junit:junit:jar:3.8.2:test
 +- org.mortbay.jetty:jetty:jar:6.1.4:provided
 |  \- org.mortbay.jetty:servlet-api-2.5:jar:6.1.4:provided
 +- org.mortbay.jetty:jetty-util:jar:6.1.4:provided
 \- org.mortbay.jetty:jetty-management:jar:6.1.4:provided
    +- mx4j:mx4j:jar:3.0.1:provided
    \- mx4j:mx4j-tools:jar:3.0.1:provided

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to