On 26 September 2013 18:44, Leonidas Fegaras <fega...@cse.uta.edu> wrote: > Hi Sebastian, > Thank you for checking our release. > I think you clicked on the wrong tree link at our GIT repo. > The source tree is: > https://git-wip-us.apache.org/repos/asf?p=incubator-mrql.git;a=tree;h=385ba2829bdf184886ac82b5db793f1264bbcf3c;hb=385ba2829bdf184886ac82b5db793f1264bbcf3c > which corresponds exactly to the tag MRQL-0.9.0-incubating-RC1 as it is > shown on our call for votes.
The URL I clicked on was as follows which was in the first message of this vote e-mail thread: <quote> The release candidate is based on the sources tagged with MRQL-0.9.0-incubating-RC1: https://git-wip-us.apache.org/repos/asf?p=incubator-mrql.git;a=tag;h=a7f69742a21393f98d951a8bc5822ae218ffda60 </quote> I then clicked on "tree" and then "pom.xml / raw" I agree that the URL you have just provided has a pom that looks OK. But that URL was not in the original vote e-mail.. > These pom.xml files clearly have 0.9.0-incubating. So the link on our call > was correct but you clicked on the wrong git tree on the GIT page (you got > the latest tree). No, see above - the original e-mail link was wrong. > Also I am not sure about inserting 3rd party licenses on LICENSE. Spark did > that but I think it was wrong. From what i've read, LICENSE should have only > the Apache 2.0 license. No, the LICENSE file should have ALL the relevant licenses, either included or linked therefrom. > Please look at LEGAL-177, where we discussed what to put in the MRQL NOTICE > file. I already commented on that very issue. > Please let us know if you consider the rest of the problems you mentioned > blocking for this release as is. Yes, I do consider that the N&L issues are blocking. The N&L files must relate to the included bits and nothing more. The NOTICE file must include required notices and nothing more. Does the MRQL source contain any 3rd party code? If so, what, and where are the files? It looks as though some of the MRQL jar files contain JLine and CUP runtime. That seems wrong; Maven jar dependencies should be resolved using the dependency mechanism. Also, if the jars can be used together, there will be multiple copies of the classes, which is not good. Also, combining the 3rd party libraries with the MRQL code means that users cannot obtain just the binaries for MRQL itself; they will be forced to build it themselves. If there is a need to provide a bundled binary containing 3rd party jars, that is normally done in the zip/tar.gz archives containing the various components as individual jars. > Thanks > Leonidas Fegaras > > > On Sep 26, 2013, at 11:45 AM, sebb wrote: > > On 24 September 2013 13:44, Leonidas Fegaras <fega...@cse.uta.edu> wrote: > > Hello, > > This is a call for a vote on Apache MRQL 0.9.0 incubating. MRQL is a > > query processing and optimization system for large-scale, distributed > > data analysis, built on top of Apache Hadoop, Hama, and Spark. > > This is our first release. A vote was held on the MRQL developer > > mailing list and it passed with three +1 votes (plus one late vote), > > and zero -1 or 0 votes (see the vote thread [1] and result thread [2]), > > and now requires a vote on general@incubator.apache.org. The vote will > > be open for 72 hours (it will close on Friday 27/Sep/2013 at 1pm GMT) > > and passes if a majority of at least three +1 IPMC votes are cast. > > > [ ] +1 Release this package as Apache MRQL 0.9.0-incubating > > [ ] -1 Do not release this package because... > > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachemrql-055/ > > You are voting only for the source distribution. > > The source tar ball is available at: > > https://repository.apache.org/content/repositories/orgapachemrql-055/org/apache/mrql/mrql-src-dist/0.9.0-incubating/ > > The release candidate consists of the following source distribution > > archives: > > - mrql-src-dist-0.9.0-incubating.[zip|tar.gz] > > SHA1 of TGZ: 4b5c6c2df32881b77633303435cb0c99856105cd > > SHA1 of ZIP: edae1009a5ef7a7613f4da4d2d46e1c9339cb70f > > You can compile the sources using 'mvn package'. > > > In addition, the following supplementary binary distributions are provided > > for user convenience at: > > https://repository.apache.org/content/repositories/orgapachemrql-055/org/apache/mrql/mrql-bin-dist/0.9.0-incubating/ > > The binary distribution archives are: > > - mrql-bin-dist-0.9.0-incubating.[zip|tar.gz] > > SHA1 of TGZ: 27a1c569a0da333a22da260b07356673b81f539c > > SHA1 of ZIP: 6afdeb2640e6b3a31a97e44a0b5e585e6ade62ac > > > The release candidate has been signed through the key 798764F1 in: > > http://www.apache.org/dist/incubator/mrql/KEYS > > http://keyserver.kjsl.org:11371/pks/lookup?op=get&search=0xB7737C07798764F1 > > > The release candidate is based on the sources tagged with > > MRQL-0.9.0-incubating-RC1: > > https://git-wip-us.apache.org/repos/asf?p=incubator-mrql.git;a=tag;h=a7f69742a21393f98d951a8bc5822ae218ffda60 > > > That does not seem to be the correct tag, because the pom versions > include -SNAPSHOT in them. > > RAT output: > > http://people.apache.org/~fegaras/dist/MRQL-0.9.0-incubating-RC1/rat.txt > > Suitable name search: > > https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-32 > > > The vote e-mail includes the hashes for tags and archives which is > excellent, as it ties the vote to the items being voted on. > So it's unfortunate that the tag does not agree with the source archive. > > Sigs and hashes seem OK to me. > > The <name> and <description> entries in the POMs should all start > Apache MRQL so it is clear that they are part of the Apache MRQL > product. > This is necessary for clear branding. Also the <name> affects the > generated NOTICE files under META-INF. > These are currently invalid. > > It's a bit confusing to have artifact id of "gen" when all the other > ids include MRQL or mrql. > > Note: The NOTICE includes the 3rd party copyright notices for JLine > > and CUP because the JLine and the CUP runtime libraries are bundled in > > the jar files in the MRQL binary distribution (files lib/*.jar). > > This was required because the MRQL jar files must contain all the > > dependencies in order to run on Hadoop and Hama. > > > It's OK to bundle 3rd party jars (assuming that the license allows us > to do so, so no GPL for example). > However, the NOTICE and LICENSE files must only refer to the enclosing > entity. > Since the source archive does not contain CUP and JLine its N&L files > must not include references to them. > Likewise the top level N&L files in the Git repo should only refer to > files actually contained in the repo. > > Also, the NOTICE file looks wrong even for the binary jar; at *most* > two or 3 lines are needed for each external inclusion. > See http://www.apache.org/dev/licensing-howto.html#mod-notice > The licences must either be appended to the LICENSE file or you can > store them in separate files which are linked from the main LICENSE > file. > > Some of the POMs in the Nexus staging repo appear to have lost their AL > headers. > > To learn more about Apache MRQL, please visit: > > http://wiki.apache.org/mrql/ > > Thanks, > > Leonidas Fegaras > > > [1] http://markmail.org/message/nhyjdxlmas5vlg5x > > [2] http://markmail.org/message/5zsmncpimbdgfyn7 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
