Thanks for the feedback, Justin. We'll get those items checked before
our next release.

Richard.


On 27 December 2014 at 04:09, Justin Mclean <jus...@classsoftware.com> wrote:
> Hi,
>
> +1 binding
>
> I checked:
> - hashes and MD5 fine
> - DISCLAIMER exists
> - artefact has incubating in file name
> - LICENSE and NOTICE good (checked all items)
> - No unexpected binary files in source release
> - Most source code has correct headers (see below)
> - Can compile from source
>
> A few minor things missing from LICENSE, can you add these in the next 
> release.
> - superfish (MIT)
> - JQuery slideto looks be MIT not Apache to me. [1]
>
> Some other minor issues you might want to change for next release:
> - There some java files under usage/archetypes/quickstart/src/brooklyn-sample 
> that are missing Apache headers
> - Can usage/jsgui/src/main/webapp/assets/images/Sorting icons.psd be put a 
> more OS friendly format?
>
> Thanks,
> Justin
>
> 1. 
> http://web.archive.org/web/20121119015407/http://jesseprice.com/jquery-slide-to-plugin/
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to