The signature checks are fine. +1 (binding)
Good job folks on your first release. Thanks! Venkatesh On Mon, Jun 13, 2016 at 11:39 AM Julian Hyde <jh...@apache.org> wrote: > +1 (binding) > > Checked hashes, license, notice, disclaimer. Built on JDK 1.8, OS X. > > Nice work, and good luck. > > Remarks: > > 0. I noticed .github/PULL_REQUEST_TEMPLATE.md … nice! > > 1. The DISCLAIMER file is sufficient for the purposes of a source release. > But for the github audience, reaching > https://github.com/apache/incubator-beam < > https://github.com/apache/incubator-beam>, there is no disclaimer. I > think there should be a disclaimer on README.md, and at least the first > reference to beam should read “Apache Beam (incubating)”. > > 2. It’s customary (required?) for there to be a KEYS file in > https://dist.apache.org/repos/dist/dev/incubator/beam/ < > https://dist.apache.org/repos/dist/dev/incubator/beam/>. Maybe include it > next release? But I imported > https://github.com/apache/incubator-beam/blob/v0.1.0-incubating-RC3/KEYS < > https://github.com/apache/incubator-beam/blob/v0.1.0-incubating-RC3/KEYS> > easily enough. > > 3. “mvn apache-rat:check” failed due to DEPENDENCIES and > .github/PULL_REQUEST_TEMPLATE.md. Please add headers or exclusions next > time. > > Julian > > > > On Jun 12, 2016, at 11:28 PM, Sergio Fernández <wik...@apache.org> > wrote: > > > > +1 (binding) > > > > So far I've checked: signatures and digests, source releases file > layouts, > > matched git tags and commit ids, incubator suffix and disclaimer, NOTICE > > and LICENSE files, license headers (two test files from the Project > > Gutenberg don't have it) build sources in a clean environment (Maven > 3.3.9, > > OpenJDK 1.8.0_91 64-Bit, Debian amd64). > > > > The issue with the "Project Gutenberg license" needs to be clarified, as > > Justin already pointed it out. Although license looks to affect only test > > resources, this may need legal@apache check. > > > > Good work, guys! Happy to sea Bean moving forward. > > > > > > > > On Sun, Jun 12, 2016 at 1:54 AM, Davor Bonaci <da...@google.com.invalid> > > wrote: > > > >> Hi everyone, > >> Here's the first vote for the first release of Apache Beam -- version > >> 0.1.0-incubating! > >> > >> The complete staging area is available for your review, which includes: > >> * the official Apache source release to be deployed to dist.apache.org > >> [1], > >> and > >> * all artifacts to be deployed to the Maven Central Repository [2]. > >> > >> This corresponds to the tag "v0.1.0-incubating-RC3" in source control, > [3]. > >> > >> The Apache Beam community has unanimously approved this release, [4], > [5], > >> [6]. > >> > >> Please vote as follows: > >> [ ] +1, Approve the release > >> [ ] -1, Do not approve the release (please provide specific comments) > >> > >> As customary, the vote will be open for at least 72 hours. It is > adopted by > >> a majority approval with at least three PMC affirmative votes. If > approved, > >> we will proceed with the release. > >> > >> Thanks, > >> Davor > >> > >> [1] > >> > https://dist.apache.org/repos/dist/dev/incubator/beam/0.1.0-incubating/RC3/ > >> [2] > https://repository.apache.org/content/repositories/orgapachebeam-1002/ > >> [3] https://github.com/apache/incubator-beam/tree/v0.1.0-incubating-RC3 > >> [4] > >> > >> > https://lists.apache.org/thread.html/68bf80b386dde080126b51ddf3497c6801015903a705411d435d64a1@%3Cdev.beam.apache.org%3E > >> [5] > >> > >> > https://lists.apache.org/thread.html/32c991987e0abf2a09cd8afad472cf02e482af02ac35418ee8731940@%3Cdev.beam.apache.org%3E > >> [6] > >> > >> > https://lists.apache.org/thread.html/e6ffcba94ef4514e8cf5c6fed39100ee359b954c4876d3275b1bc33a@%3Cdev.beam.apache.org%3E > >> > > > > > > > > -- > > Sergio Fernández > > Partner Technology Manager > > Redlink GmbH > > m: +43 6602747925 > > e: sergio.fernan...@redlink.co > > w: http://redlink.co > >
