On Wed, Jan 11, 2017 at 9:19 PM, John D. Ament <johndam...@apache.org> wrote:
> +1 > > Few notes: > > - Add license to README.md (you have it on .travis.yml so why not?) > - The use of RELEASE creates a potentially not-repeatable build for apache > parent. > - More than the listed test failed: > > Failed tests: > ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103 ComparisonFailure > expected:<1[6]> but was:<1[1]> > StartupSettingsTest.testUsingSettingsFile:68 » Runtime > java.net.BindException:... > TenNodeThreeSeedTest.test:44->abc:78 » Runtime java.net.BindException: > Address... > TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime > java.net.BindException: Ad... > > - Your email notes that a WAR exists in > https://repository.apache.org/content/repositories/ > orgapachegossip-1002/org/apache/gossip/gossip/0.1.1-incubating/ > but > I could find no such WAR. > - While its OK for the staged release vote to use nexus, your final source > distribution must be on > - Gossip's download page is out of compliance (sort of). Specifically you > should not link to github on your downloads page. > > John > > On Wed, Jan 11, 2017 at 11:53 AM Edward Capriolo <edlinuxg...@gmail.com> > wrote: > > > I am pleased to call an IPMC vote for gossip-0.1.1-incubating. > > > > The PPMC vote thread is here: > > The vote thread is here: > > > > https://lists.apache.org/thread.html/86bf41b491a575c4751c1191f8f9d8 > ee2d17bedeac4bdef582ba5f03@%3Cdev.gossip.apache.org%3E > > > > Release this package? > > [ ] +1 yes > > [ ] +0 no opinion > > [ ] -1 Do not release this package because because... > > > > Thank you, > > Edward > > > > Below is a copy of the [RESULT] for voting: > > --------- > > The vote for gossip-0.1.1-incubating (RC2) has passed. > > > > Josh Elser +1 > > P. Taylor Goetz +1 > > Gary Dusbabek +1 > > Chandresh Pancholi +1 > > Edward Capriolo +1 > > > > The vote thread is here: > > > > https://lists.apache.org/thread.html/86bf41b491a575c4751c1191f8f9d8 > ee2d17bedeac4bdef582ba5f03@%3Cdev.gossip.apache.org%3E > > > > I am pleased to be calling this vote for the source release of Apache > > Gossip > > > > Ancillary artifacts such as poms, jars, wars, ect. can be found here: > > https://repository.apache.org/content/repositories/orgapachegossip-1002/ > > > > The Git commit ID is: > > 6720f35beb8718ae39018211f33bbff2ac782fb6 > > > > https://github.com/apache/incubator-gossip/commit/ > 6720f35beb8718ae39018211f33bbff2ac782fb6 > > > > The tag is: > > https://github.com/apache/incubator-gossip/tree/gossip- > 0.1.1-incubating-rc2 > > > > Checksums of: > > > > https://repository.apache.org/content/repositories/ > orgapachegossip-1002/org/apache/gossip/gossip/0.1.1- > incubating/gossip-0.1.1-incubating-source-release.zip > > > > https://repository.apache.org/content/repositories/ > orgapachegossip-1002/org/apache/gossip/gossip/0.1.1- > incubating/gossip-0.1.1-incubating-source-release.zip.md5 > > > > https://repository.apache.org/content/repositories/ > orgapachegossip-1002/org/apache/gossip/gossip/0.1.1- > incubating/gossip-0.1.1-incubating-source-release.zip.sha1 > > SHA1 > > <https://repository.apache.org/content/repositories/ > orgapachegossip-1002/org/apache/gossip/gossip/0.1.1- > incubating/gossip-0.1.1-incubating-source-release.zip.sha1SHA1>: > > 66dfe09a925fe2650fd3d85c97fdc10b049a9776 > > MD5: 2695f11e714edb1364a4105b970039b8 > > > > Are confirmed: > > [edward@jackintosh tmp]$ wget > > > > https://repository.apache.org/content/repositories/ > orgapachegossip-1002/org/apache/gossip/gossip/0.1.1- > incubating/gossip-0.1.1-incubating-source-release.zip > > [edward@jackintosh tmp]$ md5sum gossip-0.1.1-incubating- > source-release.zip > > 2695f11e714edb1364a4105b970039b8 > > gossip-0.1.1-incubating-source-release.zip > > [edward@jackintosh tmp]$ sha1sum > > gossip-0.1.1-incubating-source-release.zip > > 66dfe09a925fe2650fd3d85c97fdc10b049a9776 > > gossip-0.1.1-incubating-source-release.zip > > > > Release artifacts are signed with the following key: > > http://people.apache.org/~ecapriolo/ > > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS > > > > Please download the release candidate and evaluate the necessary items > > including checking hashes, signatures, build from source, and test. > > > > Note: The end-to-end tests (ShutdownDeadtimeTest) tend to be flakey. > > https://issues.apache.org/jira/browse/GOSSIP-22 will address this > feature > > in next release. > > > > Release this package? > > [ ] +1 yes > > [ ] +0 no opinion > > [ ] -1 Do not release this package because because... > > > John, Thanks for going over that. As for the readme. that is in place to display on github. I do not see others putting the licence here. I will place it at the bottom if that is acceptable. https://github.com/apache/hbase https://github.com/apache/hive There is no WAR artifact. I coped that line as boilerplate from another project. Next release I will clean up the email RE: Failed tests: There is one flaky test. Not only does it fail, but it does not clean up well one it fails and causes the next tests to have issues. GOSSIP-22 fixes the root cause and also runs each integration tests on different ports so that a failed test causing other fallout is minimized. Gossip-22 is a significant change to an accrual failure detector so even those this FD was flaky I wanted to hold that off to next release. GOSSIP-22 tests well for me locally. Faster and not flaky. While its OK for the staged release vote to use nexus, your final source distribution must be on (I am guessing you mean the the final source distribution must be on SVN) - Gossip's download page is out of compliance (sort of). Specifically you should not link to github on your downloads page. Now that we have a release I will fix this. Thanks, Edward
