Hello,

+1 (binding)

I checked:
- name includes incubating
- disclaimer exists
- notice looks good (echo Justin's comment re: 2106 vs 2017)
- commit 6720f35beb8 is present at git://git.apache.org/incubator-gossip.git
- binary distribution builds
- gpg signatures OK (echo Justin's comment re: signing address)
- checksums OK
- no binary files in release
- can compile from source

Thanks for the release,

Drew

On Thu, Jan 12, 2017 at 1:48 AM Justin Mclean <jus...@classsoftware.com>
wrote:

> Hi,
>
> +1 binding
>
> I checked:
> - name includes incubating
> - disclaimer exists
> - notice good (but year last year - please update in next release)
> - all source files have ASF header
> - no binary files in release
> - can compile from source
>
> Next time could you please:
> - Place the artefacts for voting on in [1] that way they can be released
> with an svn mv command.
> - Can you sign the artifact with an apache email address rather than
> edlinuxg...@gmail.com.
>
> README without a license header is fine IMO [1] but no harm in including
> one either.
>
> Thanks,
> Justin
>
> 1. https://dist.apache.org/repos/dist/dev/incubator/gossip/
> 2. https://www.apache.org/legal/src-headers.html#faq-exceptions
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to