Hi, On Tue, Sep 4, 2018 at 5:02 PM Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes correct > - DISCLAIMER exits > - LICENSE is fine > - NOTICE may need a little more work (as it is bundling a couple of file from > ALv2 license software with NOTICE files) [1] > - No binary files in release > - All source files have ASF headers > - Can compile from source > > Re the NOTICE issue I’ll bring it up on the Dubbo dev list. As only a couple > of files have been “borrowed” the additions to the NOTICE should be simple > and straight forward.
How about adding the following lines: This product contains code derived from Google Guava project, which is available under a "Apache License 2.0" license. (https://github.com/google/guava). This product contains code derived from the Netty Project, which is available under a "Apache License 2.0" license. (https://github.com/netty/netty) > > Thanks, > Justin > > 1.http://www.apache.org/dev/licensing-howto.html#mod-notice > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > -- Best Regards！ Huxing --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
