Thank you Justin and Ate for your votes. Now we are +2 binding, but I guess I still need one more, right? Anyone else willing to cast another +1 binding vote?
I've reported https://issues.apache.org/jira/browse/NETBEANS-1739 to track the issues found by Justin. I'll keep that in mind and fix it by next release. Thanks for the findings. -jt On 2018/11/21 05:00:56, Justin Mclean <j...@classsoftware.com> wrote: > Hi,> > > +1 binding but there’s a LICENSE issue than needs to be fixed in the next release.> > > I checkered:> > - incubating in name> > - signatures and hashes correct> > - DISCLAIMER exists (although name of the project inside is a little odd)> > - LICENSE and NOTICE have a few minor issues (see below)> > - No unexpected binary files> > - All ASF file have ASF headers> > - Can compile from source> > > The tests also passed.> > > The NOTICE copyright year is “2017-2017” that should be 2017-2018 right?> > > The LICENSE is missing mention of (and license text) of MIT licensed Knockout [1]> > > Thanks,> > Justin> > > 1. incubator-netbeans-html4j/ko4j/src/main/resources/org/netbeans/html/ko4j/ knockout-3.4.0.js> > > > > > ---------------------------------------------------------------------> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org> > For additional commands, e-mail: general-h...@incubator.apache.org> > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
