Thanks! Your comment is really helpful. I raised two PRs as below:
- https://github.com/apache/incubator-druid/pull/7941 - https://github.com/apache/incubator-druid/pull/7945 I will backport them to 0.15.0-incubating as well if it turns out to be a release blocker. Jihoon On Fri, Jun 21, 2019 at 3:02 AM sebb <seb...@gmail.com> wrote: > On Fri, 21 Jun 2019 at 02:12, Jihoon Son <jihoon...@apache.org> wrote: > > > > Thank you for your detailed review! > > > > We will address your comments on signing keys in the future votes. > > > > Regarding the commit id, "44c9323" is the correct commit id for the tag. > > Maybe the link is not valid. > > Is https://github.com/apache/incubator-druid/commits/44c9323 or > > > https://github.com/apache/incubator-druid/tree/druid-0.15.0-incubating-rc2 > more > > valid one? > > The first one is immutable but not obvious, the second is not > guaranteed immutable. > > However you could use: > > https://github.com/apache/incubator-druid/tree/druid-0.15.0-incubating-rc2 > (44c9323 > <https://github.com/apache/incubator-druid/tree/druid-0.15.0-incubating-rc2(44c9323> > ) > > > Finally, would you elaborate more on what looks wrong to you in NOTICE > and > > NOTICE.BINARY files? > > NOTICE files should contain only what is strictly required for the > files actually contained in the bundle to which they apply. > See: > [1] > http://www.apache.org/dev/licensing-howto.html#assembling-license-and-notice > > The header looks OK, but most of the rest looks unnecessary. > > No need to mention Apache Licensed code unless the bit you have copied > has a required notice in its NOTICE file. > > In the case of the other products, they may or may not require entries > in NOTICE. > That depends on their license. > As per [1], generally BSD and MIT code does not require an entry in NOTICE. > > The last section (JetS3t) does not make sense. > > Similar considerations apply to NOTICE.BINARY > In the case of commons-codec-1.7.jar, does the binary bundle actually > include the file > DoubleMetaphoneTest ? It seems unlikely -- if not present, the entry > is not required. > > The LICENSE file likewise is generally OK (assuming it corresponds > with the software that is in the source bundle). It's good that the > software versions are mentioned. However the license pointer is > missing for the Porter Stemmer. It can be guessed from the previous > entry, so that is not a blocker. > > > We will fix them if necessary for this release. > > I'll leave that to others to decide, but if I were release manager, I > would fix them before release. > > > Jihoon > > > > On Thu, Jun 20, 2019 at 9:46 AM sebb <seb...@gmail.com> wrote: > > > > > On Thu, 20 Jun 2019 at 03:39, Jihoon Son <jihoon...@apache.org> wrote: > > > > > > > > Hi IPMC, > > > > > > > > The Apache Druid community has voted on and approved a proposal to > > > release > > > > Apache Druid (incubating) 0.15.0 (rc2). > > > > > > > > We now kindly request the Incubator PMC members review and vote on > this > > > > incubator release. > > > > > > > > Apache Druid (incubating) is a high performance analytics data store > for > > > > event-driven data. > > > > > > > > The community voting thread can be found here: > > > > > > > > https://lists.apache.org/thread.html/f4b1b708bcb7e6ec08e6a9cfcb2c0dfcb565fab353ccbb8c5f362218@%3Cdev.druid.apache.org%3E > > > > > > > > The release notes are available here: > > > > https://github.com/apache/incubator-druid/issues/7854 > > > > > > > > The release candidate has been tagged in GitHub as > > > > druid-0.15.0-incubating-rc2 (44c9323), available here: > > > > > > > > https://github.com/apache/incubator-druid/releases/tag/druid-0.15.0-incubating-rc2 > > > > > > I'm not sure that's the correct URL for the tag; it points to a couple > > > of archives. > > > > > > I would expect a pointer to the source code. > > > This should use the commit id that corresponds to the release > > > candidate tag, i.e. the commit id that corresponds to > > > > https://github.com/apache/incubator-druid/tree/druid-0.15.0-incubating-rc2 > > > AIUI only commit ids are truly immutable > > > > > > The NOTICE and NOTICE.BINARY files look wrong to me; they have a lot > > > of superfluous text. > > > > > > > The artifacts to be voted on are located here: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/druid/0.15.0-incubating-rc2/ > > > > > > > > A staged Maven repository is available for review at: > > > > > https://repository.apache.org/content/repositories/orgapachedruid-1007/ > > > > > > > > Release artifacts are signed with the key [95574000]: > > > > https://people.apache.org/keys/committer/jihoonson.asc > > > > > > > > This key and the key of other committers can also be found in the > > > project's > > > > KEYS file here: > > > > https://dist.apache.org/repos/dist/release/incubator/druid/KEYS > > > > > > > > As part of the validation process, the release artifacts can be > generated > > > > from source by running: > > > > mvn clean install -Papache-release,dist > > > > > > > > The RAT license check can be run from source by: > > > > mvn apache-rat:check -Prat > > > > > > > > This vote will be open for at least 72 hours. The vote will pass if a > > > > majority of at least three +1 IPMC votes are cast. > > > > > > > > [ ] +1 Release this package as Apache Druid (incubating) 0.15.0 > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > [ ] -1 Do not release this package because... > > > > > > > > Thank you IPMC! We appreciate your efforts in helping the Apache > Druid > > > > community to validate this release. > > > > > > > > On behalf of the Apache Druid PPMC, > > > > Jihoon > > > > > > > > Apache Druid (incubating) is an effort undergoing incubation at The > > > Apache > > > > Software Foundation (ASF), sponsored by the Apache Incubator. > Incubation > > > is > > > > required of all newly accepted projects until a further review > indicates > > > > that the infrastructure, communications, and decision making process > have > > > > stabilized in a manner consistent with other successful ASF projects. > > > While > > > > incubation status is not necessarily a reflection of the > completeness or > > > > stability of the code, it does indicate that the project has yet to > be > > > > fully endorsed by the ASF. > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
