Hi, +1 from me.
I checked: - Incubating in name - Disclaimer exists - LICENSE is fine - NOTICE is fine - No unexpected binary files - Code compiles and tests successfully run Kind Regards, Furkan KAMACI On Mon, Jul 29, 2019 at 7:01 PM leerho <lee...@gmail.com> wrote: > Additional information accidentally omitted from the vote letter: > > 8. Build Guide: > > The DataSketches-memory component is pure Java and is structured as a Maven > project. You must compile using JDK 8. There is one run-time dependency > and, of course, a number of test and Maven plugin dependencies, all of > which can be resolved by Maven. > > This component is a set of low-level library functions that is used by the > other DataSketches components. It has no user interface so the only thing > you can do is compile and run the unit tests. > There are two types of tests: normal unit tests and tests run by the strict > profile. To run normal unit tests: > > $ mvn clean test > > To run the strict profile tests: > > $ mvn clean test -P strict > > Note also that when running the test suite, you might get the following > message: > > SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". > SLF4J: Defaulting to no-operation (NOP) logger implementation > SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for > further > details. > > This is normal. It just indicates that in your environment, you do not > have a logger in your class-path so the default logger of a no-op is used > instead. > > To install jars in your local .m2 repository: > > $ mvn clean install > > If you are interested in the actual functions of the Memory, you will need > to write some code that calls the Memory functions. > > 9. The documentation for the DataSketches Memory component is part of the > website. > > Overview documentation: > - https://datasketches.github.io/docs/Memory/MemoryPackage.html > - https://datasketches.github.io/docs/Memory/MemoryPerformance.html > > Javadocs: > https://datasketches.github.io/api/memory/snapshot/apidocs/index.html > > This Memory component has been split out from the rest of the DataSketches > code because there have been a number of requests from folks that are > interested in these high-performance functions independently of the > remainder of the DataSketches library. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > Lee > lee...@apache.org > > On Sun, Jul 28, 2019 at 10:09 PM leerho <lee...@gmail.com> wrote: > > > Hello Apache general@incubator community. > > > > 1. This is a call for vote to release Apache DataSketches-memory version: > > 1.0.0-incubating-RC2 > > > > NOTE 1: This is one component of the DataSketches library which needs to > > be released first as other repositories have a dependency on this one. > Once > > this is released, the other components of the library will be able to be > > released. > > > > > > 2. Results from the PPMC vote (open for more than 102 hours not counting > > the weekend) > > > > - 5 votes were cast. All of the votes were (+1). Two of the votes were > > from Mentors. > > > > - The vote thread can be found at: > > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > > > > 3. Testing/actions/votes performed by the voters: > > > > - Lee Rhodes: (+1) > > - All of the code has been properly refactored with > > "org.apache.datasketches...". > > - All source files have the proper Apache license and have been > > checked with the Maven Rat Plugin. > > - The code passes all tests with a coverage of > 98%. > > - Checkstyle: passes with no warnings. This uses the configuration > > MemoryCheckstyle.xml located in the /tools/ directory. > > - SpotBugs: passes with no bugs found: This uses the configuration > > FindBugsExcludeFilter.xml located in the /tools/directory. > > - mvn clean javadoc:javadoc produces no javadoc errors. The javadocs > > will be found under /target/site/ > > - mvn versions:display-plugin-updates. This has 2 warnings, but the > > versions are inherited from the super-pom. > > - [WARNING] The following plugins do not have their version > > specified: > > - [WARNING] maven-assembly-plugin ..................... (from > > super-pom) 2.6 > > - [WARNING] maven-compiler-plugin ..................... (from > > super-pom) 3.5. > > Note: In the next release we can add the version numbers to the > > local pom to eliminate this warning. > > - The assembly file signatures and checksums have been verified. > > > > - Alex Saydakov: (+1) > > - mvn package > > - mvn test > > > > - Jon Malkin: (+1) > > - mvn test > > - mvn install > > > > - Furkan Kamaci (+1 IPMC Member) > > - incubating in name > > - Disclamer exists > > - License is fine > > - Notice is fine > > - no unexpected binary files > > - code compiles and tests successfully run > > > > - Kenneth Knowles (+1 IPMC Member) > > Double checked: > > - DISCLAIMER, LICENSE and NOTICE > > - mvn install succeeded > > > > > > 4. Source repository: > > https://github.com/apache/incubator-datasketches-memory > > > > - Git Tag for this release: 1.0.0-incubating-RC2 > > > > > https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC2 > > > > - Git HashId for this release starts with: ec8f16e > > > > > > 5. DIST/DEV: The release candidate assembly: > > > > - > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC2/apache-datasketches-memory-1.0.0-incubating-src.zip > > > > - The assembly file has been signed with --keyid-format SHORT : > 8CD4A902 > > > > - The public signing key can be found in the KEYS file: > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > - Upon acceptance, the above assembly and signatures will be deployed > > into the official Apache release repository: > > > > > https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/ > > > > > > 6. NEXUS: The Jar and pom attributes have been deployed to Nexus Staging > > Repository "orgapachedatasketches-1000", which can be examined from the > > Nexus UI. > > > > - Upon acceptance, the staging repository holding the artifacts will > be > > closed and then the artifacts will be released. > > > > > > 7. Note that Mentors k...@apache.org and furkankam...@gmail.com as well > > as pa...@asert.com.au have made a number of valuable suggestions on > > improving the process that are recorded in a separate thread. None of > the > > suggestions impact the voting for this release. This has been valuable > > learning for us and we will be implementing these suggestions in the next > > release. > > > > Lee > > lee...@apache.org > > > > >