Hi,
as it seems like the PPMC vote is already closed I'll repost my vote here...
+1 (binding)
I checked:
- Checked out release
- Verified hashes
- Verified incubating in names
- No binaries in release
- Checked NOTICE and LICENSE.txt, README
- Started superset from sources using ` docker-compose run --rm superset
./docker-init.sh` -> Works
Some (minor) issues found:
- No KEYS file found in 'dev' repository only in RELEASE
- The Key used to sign is not very "thrustworhy" (short chain of thrust)
- LICENSE.txt contains infomrations which I think should belong to NOTICE (but
I'm not 100% sure)
- README is not very human readable. Perhaps one should split it in one for
humas and one which is sued to generate the Homepage?
- Start / Installation instructions should be directly in the README (IMHO)
- Following warning while building docker Container:
```
debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype
dpkg-preconfigure: unable to re-open stdin:
```
- The docker start script asks me for input (admin name, ...). This is not
listed in the installation instructions
- Another Hint: Generally its good to start a [DISCUSS] Thread parallel to the
[VOTE] Thread. Then it becomes easier to follow the VOTE thread as it stays
"cleaner".
Good Job!
Best
Julian
Am 19.08.19, 15:11 schrieb "Jim Jagielski" <j...@jagunet.com>:
+1 (binding)
> On Aug 19, 2019, at 12:41 AM, Maxime Beauchemin
<maximebeauche...@gmail.com> wrote:
>
> Hi IPMC,
>
> The Apache Superset community has voted on and approved a proposal to
> release
> Apache Superset (incubating) 0.34.0 (rc1). *This would be the first Apache
> release of Superset.*
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> Apache Superset (incubating) is a business intelligence web application
>
> The community voting thread can be found here:
>
https://lists.apache.org/thread.html/c9ad3ce592a695ceeabfa92969c00c0d7be8e3420b6a221c7e806f40@%3Cdev.superset.apache.org%3E
>
> The release candidate has been tagged in GitHub as tag 0.34.0rc1
> <https://github.com/apache/incubator-superset/releases/tag/0.34.0rc1>,
> available here:
> https://github.com/apache/incubator-superset/releases/tag/0.34.0rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/incubator/superset/
>
> Release artifacts are signed with the key located here:
> https://dist.apache.org/repos/dist/release/incubator/superset/KEYS
>
> This vote will be open for at least 72 hours. The vote will pass if a
> majority of at least three +1 IPMC votes are cast.
>
> [ ] +1 Release this package as Apache Superset (incubating) 0.15.1
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Thank you IPMC! We appreciate your efforts in helping the Apache Superset
> community to validate this release.
>
> On behalf of the Apache Superset Community,
>
> Max
>
> ------------------------------------------------
>
> Apache Superset (incubating) is an effort undergoing incubation at The
> Apache
> Software Foundation (ASF), sponsored by the Apache Incubator. Incubation
is
> required of all newly accepted projects until a further review indicates
> that the infrastructure, communications, and decision making process have
> stabilized in a manner consistent with other successful ASF projects.
While
> incubation status is not necessarily a reflection of the completeness or
> stability of the code, it does indicate that the project has yet to be
> fully endorsed by the ASF.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
