Hi Justin, Many thanks for testing our release out and for your feedback.
Comments inline below. Would the fixes proposed below for a subsequent release be sufficient for you to change your vote or should we implement them now and revote? Regards. John > -----Original Message----- > From: Justin Mclean <jus...@classsoftware.com> > Sent: 15 January 2020 02:04 > To: general@incubator.apache.org > Subject: Re: [VOTE] Release Apache Milagro (incubating) Crypto-C V2.0.1 > > Hi, > > Currently I’m -1 on this release due to the author tags, which may imply it > contains 3rd party code, whose licenses not listed in LICENSE. There's > probably an explanation for why they are there and if given I’ll change my > vote. Most of the author tags are leftover from the initial software grant from CertiVox and have no IP consequences. However, we'll remove ALL author tags in the next release. > > I checked: > - incubating in name > - signatures and disclaimer exist > - LICENSE is incorrect as it contains "Copyright 2019 The Apache Software > Foundation” in the appendix. We'll fix in the next release. > - NOTICE has incorrect year Also to be fixed in the next release. > - A couple of files are missing ASF headers [1][2][3][4] (assuming they are > files > created at the ASF) Also to be fixed in the next release. > - can compile from source > > The code contains a large number of author tags, author tags are usually > frowned on at the ASF. Some are from current committers and others are > not. What this in the original code when donated or have they been added > later? Is any of this code 3rd party code with an incorrect ASF header? > > I also had one test fail test_python_mpin_install_BLS381 Please can you provide details of your environment - particularly the OS/version and also what version of Python you're running? We thought this might be due to Python 2.7 (the README incorrectly states that 2.7 is supported - also to be resolved in the next release), however I can't replicate the issue using Python 2.7 on Ubuntu 18, so it may be some other issue. > > Thanks, > Justin > > 1. incubator-milagro-crypto-c- > 2.0.1/cmake/determine_word_size/check_16.c > 2. incubator-milagro-crypto-c- > 2.0.1/cmake/determine_word_size/check_32.c > 3. incubator-milagro-crypto-c- > 2.0.1/cmake/determine_word_size/check_64.c\ > 4. incubator-milagro-crypto-c-2.0.1/scripts/buildMulti.sh > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org
smime.p7s
Description: S/MIME cryptographic signature
