Hi,
We need to figure out where these files came from. If they originated from Bitnine, we should keep their original header and mention them in NOTICE/LICENSE. Otherwise, only keep the ASF header for them. ------------------------------------------------------------------------------ Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) & AGE (Incubating) mentor Twitter, @tristaZero On 10/25/2021 11:24，Eya Badal Abdisho<eya.abdi...@bitnine.net> wrote： Hello Justin, Thank you for your feedback. The issue with hashes and Signatures on the website for each download is fixed. We created a download page and added the required information as mentioned before: http://age.apache.org/ <http://age.apache.org/#> It is under the download then versions page. Based on your feedback should we remove "Postgresql Copyright" from our NOTICE and add "Copyright 2020 Bitnine Co., Ltd.”? Please advise. Best regards, Eya Badal On Sat, Oct 23, 2021 at 5:27 PM Justin Mclean <jus...@classsoftware.com> wrote: Hi, Sorry but it’s -1 (binding) as there is no download page and the download links on the home page do not have hashes and signatures. This was brought up on this list recently and was asked to be corrected. Also see other issues below. In the release: - incubating in name - signatures and hashes are fine - LICENSE is missing information from [1][2] - NOTICE is incorrect. There should be no need for "This product contains software PostgreSQL…” unless headers have been replace with permission or there was a software grant from PostgreSQL. This has previously been mentioned (in vote on 0.4.0 release). Also see issue with [1][2]. - If seem unlikely that [1][2] should have ASF headers? In general the licensing of the file should stay as it is unless significant modifications have ben done. Looking at the history it seems if was originally "Copyright 2020 Bitnine Co., Ltd.” Why is this not mentioned in NOTICE? Was permission given to change the headers? - Probably similar issue with these file [3][4] - No unexpected binary files - unable to compile but assume that my setup. src/backend/catalog/ag_graph.c:67:15: error: assigning to 'Oid' (aka 'unsigned int') from incompatible type 'void' Kind Regards, Justin 1. ./src/include/utils/agtype_parser.h 2. ./src/backend/utils/adt/agtype_parser.c 3. ./src/include/utils/agtype.h 4. ./src/backend/utils/adt/agtype.c --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org -- Bitnine Global, Inc. - We create value for our clients by connecting the world's data. *Eya Badal Abdisho* Technical Engineer E-mail : eya.abdi...@bitnine.net <jos...@bitnine.net> Mobile : +1 408-966-3301 3945 Freedom Cir., Suite 260, Santa Clara, CA 95054 www.bitnine.net
