+1 (non-binding) I checked: [x] Download links are valid. [x] Checksums and signatures. [x] No unexpected binary files
-- Best Regards Mingyu Chen Email: morning...@apache.org 在 2023-05-18 15:24:35，"Huajie Wang" <benj...@apache.org> 写道： >+1 (non-binding) > >I checked: > >[x] Download links are valid >[x] Checksums and signatures >[x] LICENSE/NOTICE files exist >[x] All source files have ASF headers >[x] Can compile from source > > >Best, >Huajie Wang > > > >Kent Yao <y...@apache.org> 于2023年5月18日周四 14:57写道： > >> Hi Justin & Yu. Thanks for the explaination. >> >> +1(non-binding) >> >> Kent Yao >> >> >> On 2023/05/18 06:49:14 Yu Li wrote: >> > Thanks for the note Kent. Scala has indeed changed to ALv2 today, but >> > before Dec. 2018 it used BSD 3-clause license, and the scala version >> > depended in Paimon is 2.12.7, which was released in Sep. 2018. >> > >> > I also noticed this during review and commented on the PR [1], JFYI. >> > >> > Please let us know if any further concerns. Thanks. >> > >> > Best Regards, >> > Yu >> > >> > [1] >> > >> https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188058405 >> > >> > >> > On Thu, 18 May 2023 at 14:43, Kent Yao <y...@apache.org> wrote: >> > >> > > The NOTICE and the copy of LICENSE.scala in paimon-codegen are >> incorrect >> > > due to https://www.scala-lang.org/news/license-change.html >> > > >> > > I am not sure if this is a blocker or not. >> > > >> > > Kent Yao >> > > >> > > On 2023/05/18 06:21:09 Becket Qin wrote: >> > > > +1 (binding) >> > > > >> > > > - verified signature and checksum >> > > > - verified license in the source code >> > > > - locally built the source and ran all the tests. (Some of the tests >> are >> > > > occasionally failing due to testcontainer timeout, but does not seem >> a >> > > > blocker of release). >> > > > >> > > > Thanks, >> > > > >> > > > Jiangjie (Becket) Qin >> > > > >> > > > >> > > > >> > > > On Wed, May 17, 2023 at 10:33 AM Yu Li <car...@gmail.com> wrote: >> > > > >> > > > > +1 (binding) >> > > > > >> > > > > - Checked release file name and location: *OK* >> > > > > >> > > > > - Checked sum and signatures: *OK* >> > > > > >> > > > > - Checked DISCLAIMER file exists: *OK* >> > > > > >> > > > > - Checked LICENSE and NOTICE files: *OK* >> > > > > >> > > > > * License of 3rd-party code contained correctly mentioned in >> > > LICENSE: >> > > > > *OK* >> > > > > >> > > > > * Included dependencies are mentioned in LICENSE: *OK* >> > > > > >> > > > > * Un-included software dependencies are not mentioned in >> LICENSE or >> > > > > NOTICE: *OK* >> > > > > >> > > > > * Relevant part of NOTICE files of referred/contained ASF codes >> > > added >> > > > > into NOTICE: *OK* >> > > > > >> > > > > * NOTICE year: *OK* >> > > > > >> > > > > - Checked no binary files in source package: *OK* >> > > > > >> > > > > - Checked compile from source: *OK* (JDK 8u181) >> > > > > >> > > > > - Checked UT could pass: *OK* (JDK 8u181) >> > > > > >> > > > > Best Regards, >> > > > > Yu >> > > > > >> > > > > >> > > > > On Mon, 15 May 2023 at 17:53, Jingsong Li <jingsongl...@gmail.com> >> > > wrote: >> > > > > >> > > > > > Hello Incubator PMC, >> > > > > > >> > > > > > The Apache Paimon community has voted and approved the release of >> > > > > > Apache Paimon(incubating) 0.4.0-incubating rc5. We now kindly >> request >> > > > > > the IPMC members review and vote for this release. >> > > > > > >> > > > > > Apache Paimon(incubating) is a streaming data lake platform that >> > > > > > supports high-speed data ingestion, change data tracking and >> > > efficient >> > > > > > real-time analytics. >> > > > > > >> > > > > > Paimon community vote thread: >> > > > > > >> > > > > > https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz >> > > > > > >> > > > > > Vote result thread: >> > > > > > >> > > > > > https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b >> > > > > > >> > > > > > The official Apache source release to be deployed to >> dist.apache.org >> > > : >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > >> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/ >> > > > > > >> > > > > > This source release has been signed with a PGP available here: >> > > > > > >> > > > > > https://downloads.apache.org/incubator/paimon/KEYS >> > > > > > >> > > > > > All artifacts to be deployed to the Maven Central Repository: >> > > > > > >> > > > > > >> > > >> https://repository.apache.org/content/repositories/orgapachepaimon-1016/ >> > > > > > >> > > > > > Git branch for the release: >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > >> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5 >> > > > > > >> > > > > > >> > > > > >> > > >> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5 >> > > > > > >> > > > > > Please download, verify, and test. >> > > > > > >> > > > > > The VOTE will pass after 3 binding approve. >> > > > > > >> > > > > > [ ] +1 approve >> > > > > > [ ] +0 no opinion >> > > > > > [ ] -1 disapprove with the reason >> > > > > > >> > > > > > To learn more about apache paimon, please see >> > > https://paimon.apache.org/ >> > > > > > >> > > > > > Checklist for reference: >> > > > > > >> > > > > > [ ] Download links are valid. >> > > > > > [ ] Checksums and signatures. >> > > > > > [ ] LICENSE/NOTICE files exist >> > > > > > [ ] No unexpected binary files >> > > > > > [ ] All source files have ASF headers >> > > > > > [ ] Can compile from source >> > > > > > >> > > > > > Best, >> > > > > > Jingsong >> > > > > > >> > > > > > >> --------------------------------------------------------------------- >> > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > > > > For additional commands, e-mail: >> general-h...@incubator.apache.org >> > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > >> > > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >>
