Hi,

There are many different versions of the maven wrapper, both before and after 
it was donated to the ASF. However the ASF version does need to be mentioned in 
LICENSE [1] and NOTICE [2].

Kind Regards,
Justin

1. https://infra.apache.org/licensing-howto.html#alv2-dep
2. https://github.com/apache/maven-wrapper/blob/master/NOTICE

> On 19 May 2023, at 12:16 pm, Jingsong Li <jingsongl...@gmail.com> wrote:
> 
> Thanks all for your voting.
> 
> Thanks Calvin and Yu Li,
> 
> About mvn* files, yes, Paimon sources contain Maven Wrapper
> Distribution. [1] We should add copyright in NOTICE. Paimon uses
> distribution without any additional modifications, so there is no need
> to add it to the license?
> 
> I will prepare a PR to fix this.
> 
> [1] https://maven.apache.org/wrapper/maven-wrapper-distribution/
> 
> Best,
> Jingsong
> 
> ================================
> 
> By the way,
> Maven Wrapper is widely used. I did a statistics, many projects didn't
> notice this:
> 
> Without copyright:
> https://github.com/apache/camel
> https://github.com/apache/shenyu
> https://github.com/apache/dubbo
> https://github.com/apache/dolphinscheduler
> https://github.com/apache/ignite
> https://github.com/apache/zeppelin
> https://github.com/apache/linkis
> https://github.com/apache/camel
> https://github.com/apache/iotdb
> https://github.com/apache/ratis
> https://github.com/apache/flink
> https://github.com/apache/pulsar
> https://github.com/apache/shardingsphere
> https://github.com/apache/curator
> https://github.com/apache/flume
> 
> With copyright:
> https://github.com/apache/skywalking
> https://github.com/apache/incubator-seatunnel
> https://github.com/apache/incubator-streampark
> 
> Do we need to send a group email to remind each community to add copyright?
> 
> On Fri, May 19, 2023 at 12:15 AM Yu Li <car...@gmail.com> wrote:
>> 
>> Hi Calvin,
>> 
>> Thanks for the careful checking.
>> 
>> About the AWS-SDK and PalDB mentioning in NOTICE file, since the referenced
>> codes (as mentioned in the LICENSE file) are irrelevant to the other
>> contents of AWS-SDK [1] and PalDB's [2] NOTICE files, only the "Copyright"
>> lines are bubbled up according to the rules [3] (the content of the
>> dependency's NOTICE file is analyzed with relevant portions bubbled up into
>> the top-level NOTICE file).
>> 
>> About the mvn* files included in the source package, I think there are
>> indeed references from the maven-wrapper project such as mvnw
>> [4]. @Jingsong could you help confirm this? If so, we need to update our
>> NOTICE and LICENSE files accordingly [5], and please prepare a PR to fix
>> this.
>> 
>> Although maven-wrapper is an ASF project [6], I'm not quite sure whether
>> this is a blocker for the release, or whether we could fix it in a later
>> release. Seems that it should be categorized as a legal issue thus taken as
>> a blocker? @Calvin @Justin Mclean <jus...@classsoftware.com> and others,
>> may I know your thoughts on this? Thanks.
>> 
>> Best Regards,
>> Yu
>> 
>> [1] https://github.com/aws/aws-sdk-java/blob/master/NOTICE.txt
>> [2] https://github.com/linkedin/PalDB/blob/master/NOTICE
>> [3] https://infra.apache.org/licensing-howto.html#alv2-dep
>> [4]
>> https://github.com/apache/maven-wrapper/blob/master/maven-wrapper-distribution/src/resources/mvnw
>> [5] https://infra.apache.org/licensing-howto.html#bundle-asf-product
>> [6] https://maven.apache.org/wrapper/
>> 
>> On Thu, 18 May 2023 at 16:39, Calvin Kirs <k...@apache.org> wrote:
>> 
>>> Hi,
>>>   -1(binding)
>>> The mvn* files in the source package come from maven-wrapper, which is
>>> not reflected in the License and NOTICE.
>>> 
>>> The AWS-SDK and PalDB mentioned in the NOTICE do not seem to be the
>>> original NOTICE files, can you make sure?
>>> 
>>> I checked:
>>> - Checksum and signature are fine.
>>> - Incubating in name
>>> 
>>> On Thu, May 18, 2023 at 3:40 PM Mingyu Chen <morning...@163.com> wrote:
>>>> 
>>>> +1 (non-binding)
>>>> 
>>>> I checked:
>>>> [x] Download links are valid.
>>>> [x] Checksums and signatures.
>>>> [x] No unexpected binary files
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> Best Regards
>>>> Mingyu Chen
>>>> 
>>>> Email:
>>>> morning...@apache.org
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 在 2023-05-18 15:24:35,"Huajie Wang" <benj...@apache.org> 写道:
>>>>> +1 (non-binding)
>>>>> 
>>>>> I checked:
>>>>> 
>>>>> [x] Download links are valid
>>>>> [x] Checksums and signatures
>>>>> [x] LICENSE/NOTICE files exist
>>>>> [x] All source files have ASF headers
>>>>> [x] Can compile from source
>>>>> 
>>>>> 
>>>>> Best,
>>>>> Huajie Wang
>>>>> 
>>>>> 
>>>>> 
>>>>> Kent Yao <y...@apache.org> 于2023年5月18日周四 14:57写道:
>>>>> 
>>>>>> Hi Justin & Yu. Thanks for the explaination.
>>>>>> 
>>>>>> +1(non-binding)
>>>>>> 
>>>>>> Kent Yao
>>>>>> 
>>>>>> 
>>>>>> On 2023/05/18 06:49:14 Yu Li wrote:
>>>>>>> Thanks for the note Kent. Scala has indeed changed to ALv2 today,
>>> but
>>>>>>> before Dec. 2018 it used BSD 3-clause license, and the scala version
>>>>>>> depended in Paimon is 2.12.7, which was released in Sep. 2018.
>>>>>>> 
>>>>>>> I also noticed this during review and commented on the PR [1], JFYI.
>>>>>>> 
>>>>>>> Please let us know if any further concerns. Thanks.
>>>>>>> 
>>>>>>> Best Regards,
>>>>>>> Yu
>>>>>>> 
>>>>>>> [1]
>>>>>>> 
>>>>>> 
>>> https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188058405
>>>>>>> 
>>>>>>> 
>>>>>>> On Thu, 18 May 2023 at 14:43, Kent Yao <y...@apache.org> wrote:
>>>>>>> 
>>>>>>>> The NOTICE and the copy of LICENSE.scala in paimon-codegen are
>>>>>> incorrect
>>>>>>>> due to https://www.scala-lang.org/news/license-change.html
>>>>>>>> 
>>>>>>>> I am not sure if this is a blocker or not.
>>>>>>>> 
>>>>>>>> Kent Yao
>>>>>>>> 
>>>>>>>> On 2023/05/18 06:21:09 Becket Qin wrote:
>>>>>>>>> +1 (binding)
>>>>>>>>> 
>>>>>>>>> - verified signature and checksum
>>>>>>>>> - verified license in the source code
>>>>>>>>> - locally built the source and ran all the tests. (Some of the
>>> tests
>>>>>> are
>>>>>>>>> occasionally failing due to testcontainer timeout, but does not
>>> seem
>>>>>> a
>>>>>>>>> blocker of release).
>>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> 
>>>>>>>>> Jiangjie (Becket) Qin
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> On Wed, May 17, 2023 at 10:33 AM Yu Li <car...@gmail.com>
>>> wrote:
>>>>>>>>> 
>>>>>>>>>> +1 (binding)
>>>>>>>>>> 
>>>>>>>>>> - Checked release file name and location: *OK*
>>>>>>>>>> 
>>>>>>>>>> - Checked sum and signatures: *OK*
>>>>>>>>>> 
>>>>>>>>>> - Checked DISCLAIMER file exists: *OK*
>>>>>>>>>> 
>>>>>>>>>> - Checked LICENSE and NOTICE files: *OK*
>>>>>>>>>> 
>>>>>>>>>>   * License of 3rd-party code contained correctly mentioned
>>> in
>>>>>>>> LICENSE:
>>>>>>>>>> *OK*
>>>>>>>>>> 
>>>>>>>>>>   * Included dependencies are mentioned in LICENSE: *OK*
>>>>>>>>>> 
>>>>>>>>>>   * Un-included software dependencies are not mentioned in
>>>>>> LICENSE or
>>>>>>>>>> NOTICE: *OK*
>>>>>>>>>> 
>>>>>>>>>>   * Relevant part of NOTICE files of referred/contained ASF
>>> codes
>>>>>>>> added
>>>>>>>>>> into NOTICE: *OK*
>>>>>>>>>> 
>>>>>>>>>>   * NOTICE year: *OK*
>>>>>>>>>> 
>>>>>>>>>> - Checked no binary files in source package: *OK*
>>>>>>>>>> 
>>>>>>>>>> - Checked compile from source: *OK* (JDK 8u181)
>>>>>>>>>> 
>>>>>>>>>> - Checked UT could pass: *OK* (JDK 8u181)
>>>>>>>>>> 
>>>>>>>>>> Best Regards,
>>>>>>>>>> Yu
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> On Mon, 15 May 2023 at 17:53, Jingsong Li <
>>> jingsongl...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>>> 
>>>>>>>>>>> Hello Incubator PMC,
>>>>>>>>>>> 
>>>>>>>>>>> The Apache Paimon community has voted and approved the
>>> release of
>>>>>>>>>>> Apache Paimon(incubating) 0.4.0-incubating rc5. We now
>>> kindly
>>>>>> request
>>>>>>>>>>> the IPMC members review and vote for this release.
>>>>>>>>>>> 
>>>>>>>>>>> Apache Paimon(incubating) is a streaming data lake platform
>>> that
>>>>>>>>>>> supports high-speed data ingestion, change data tracking and
>>>>>>>> efficient
>>>>>>>>>>> real-time analytics.
>>>>>>>>>>> 
>>>>>>>>>>> Paimon community vote thread:
>>>>>>>>>>> 
>>>>>>>>>>> 
>>> https://lists.apache.org/thread/wkqlokj752vm097wrqmks87mkl30bzoz
>>>>>>>>>>> 
>>>>>>>>>>> Vote result thread:
>>>>>>>>>>> 
>>>>>>>>>>> 
>>> https://lists.apache.org/thread/1j7zd3fv11jcryy913d1rbpj84ysbx7b
>>>>>>>>>>> 
>>>>>>>>>>> The official Apache source release to be deployed to
>>>>>> dist.apache.org
>>>>>>>> :
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>> https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.4.0-incubating-rc5/
>>>>>>>>>>> 
>>>>>>>>>>> This source release has been signed with a PGP available
>>> here:
>>>>>>>>>>> 
>>>>>>>>>>> https://downloads.apache.org/incubator/paimon/KEYS
>>>>>>>>>>> 
>>>>>>>>>>> All artifacts to be deployed to the Maven Central
>>> Repository:
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>> https://repository.apache.org/content/repositories/orgapachepaimon-1016/
>>>>>>>>>>> 
>>>>>>>>>>> Git branch for the release:
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>> https://github.com/apache/incubator-paimon-shade/tree/release-0.4.0-incubating-rc5
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>> https://github.com/apache/incubator-paimon/tree/release-0.4.0-incubating-rc5
>>>>>>>>>>> 
>>>>>>>>>>> Please download, verify, and test.
>>>>>>>>>>> 
>>>>>>>>>>> The VOTE will pass after 3 binding approve.
>>>>>>>>>>> 
>>>>>>>>>>> [ ] +1 approve
>>>>>>>>>>> [ ] +0 no opinion
>>>>>>>>>>> [ ] -1 disapprove with the reason
>>>>>>>>>>> 
>>>>>>>>>>> To learn more about apache paimon, please see
>>>>>>>> https://paimon.apache.org/
>>>>>>>>>>> 
>>>>>>>>>>> Checklist for reference:
>>>>>>>>>>> 
>>>>>>>>>>> [ ] Download links are valid.
>>>>>>>>>>> [ ] Checksums and signatures.
>>>>>>>>>>> [ ] LICENSE/NOTICE files exist
>>>>>>>>>>> [ ] No unexpected binary files
>>>>>>>>>>> [ ] All source files have ASF headers
>>>>>>>>>>> [ ] Can compile from source
>>>>>>>>>>> 
>>>>>>>>>>> Best,
>>>>>>>>>>> Jingsong
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>> To unsubscribe, e-mail:
>>> general-unsubscr...@incubator.apache.org
>>>>>>>>>>> For additional commands, e-mail:
>>>>>> general-h...@incubator.apache.org
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>>>>>>> For additional commands, e-mail:
>>> general-h...@incubator.apache.org
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>>>>> For additional commands, e-mail: general-h...@incubator.apache.org
>>>>>> 
>>>>>> 
>>> 
>>> 
>>> 
>>> --
>>> Best wishes!
>>> CalvinKirs
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>> For additional commands, e-mail: general-h...@incubator.apache.org
>>> 
>>> 

Reply via email to