Hi Justin: Thanks very much for your patient review. We have checked the issues you mentioned. Regarding issue [1], There is an incorrect license header. We'll fix it soon, Regarding the issue [2], We have declared the license in the LICENSE[3] and we have submitted a PR[4] to remove the iconfont link. Could you please check if the issue has been resolved? Regarding the issue [5] This file was written by our developers and not copied from any other file. Perhaps we didn't understand your meaning. Could you please clarify more details?
[1] ./streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/aspect/StreamParkAspect.java [2] ./streampark-console/streampark-console-webapp/src/components/Icon/src/SvgIcon.vue [3] https://github.com/apache/incubator-streampark/blob/dev-2.1.2/LICENSE#L214 [4] https://github.com/apache/incubator-streampark/pull/3319 [5] ./streampark-console/streampark-console-webapp/src/components/Form/src/hooks/useFormEvents.ts Best, Huajie Wang Justin Mclean <jus...@classsoftware.com> 于2023年11月7日周二 01:15写道： > Hi, > > Sorry, its -1 (binding) due to 3rd party code in the release. > > I checked: > - incubating in the name > - signature and hashes are fine > - disclaimer exists > - License (and perhaps NOTICE) is missing 3rd party code licenses > - No unexpected binary files > - Source files have ASF headers, but there may be some issues > - did not compile from source > > Files misisng from license include [1], and these files which may have > incorrect headers as well [2] (this comes from IconFont?) and [3] (Vue3 > template?). Are there any other files from StreamX that have ASF headers? > Are [2][3] really ASF files? Are there other files that have been copied > here? It might also be that the ASF headers have been placed on other files > where they should not, e.g. ant design files. > > Kind Regards, > Justin > > 1. > ./streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/aspect/StreamParkAspect.java > 2. > ./streampark-console/streampark-console-webapp/src/components/Icon/src/SvgIcon.vue > > 3../streampark-console/streampark-console-webapp/src/components/Form/src/hooks/useFormEvents.ts > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
